You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "JDarDagran (via GitHub)" <gi...@apache.org> on 2023/07/04 12:58:05 UTC
[GitHub] [airflow] JDarDagran opened a new pull request, #32345: postgres: deprecate `runtime_parameters` in favor of options in `hook_params`
JDarDagran opened a new pull request, #32345:
URL: https://github.com/apache/airflow/pull/32345
Currently you need to pass `runtime_parameters` argument to explicitly set e.g. search_path in PostgresOperator.
The solution IMO is not that good. It introduces use of `psycopg2.SQL` which is not compatible with `sql` attribute type.
Moreover, it overcomplicates things, does not maintain same session variables outside of `PostgresOperator` execution and would be problematic to implement when removing `PostgresOperator` which is marked as deprecated class.
Additional motivation is that I'd like to use `PostgresOperator`'s hook after it's execution but with the same session params in OpenLineage integration. This PR allows to do this easily.
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #32345: postgres: deprecate `runtime_parameters` in favor of options in `hook_params`
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #32345:
URL: https://github.com/apache/airflow/pull/32345
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mobuchowski closed pull request #32345: postgres: deprecate `runtime_parameters` in favor of options in `hook_params`
Posted by "mobuchowski (via GitHub)" <gi...@apache.org>.
mobuchowski closed pull request #32345: postgres: deprecate `runtime_parameters` in favor of options in `hook_params`
URL: https://github.com/apache/airflow/pull/32345
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org