You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/12/08 07:47:51 UTC

[GitHub] [airflow] uranusjr commented on a diff in pull request #28213: Make live logs reading work for "other" k8s executors

uranusjr commented on code in PR #28213:
URL: https://github.com/apache/airflow/pull/28213#discussion_r1043027315


##########
airflow/utils/log/file_task_handler.py:
##########
@@ -132,6 +132,19 @@ def _render_filename(self, ti: TaskInstance, try_number: int) -> str:
     def _read_grouped_logs(self):
         return False
 
+    @staticmethod
+    def _try_read_from_k8s(queue):

Review Comment:
   This does not actually read from k8s, should it be renames to, say, `should_read_from_k8s`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org