You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "ueshin (via GitHub)" <gi...@apache.org> on 2025/08/22 22:02:25 UTC

[PR] [SPARK-53359][PYTHON] Fix Arrow UDTF to handle the results as iterator [spark]

ueshin opened a new pull request, #52104:
URL: https://github.com/apache/spark/pull/52104

   ### What changes were proposed in this pull request?
   
   Fixes Arrow UDTF to handle the results as iterator.
   
   Also including some nit improvements.
   
   ### Why are the changes needed?
   
   Creating a list from an iterator of `pa.RecordBatch` or `pa.Table` could cause a memory pressure.
   
   ### Does this PR introduce _any_ user-facing change?
   
   No.
   
   ### How was this patch tested?
   
   The existing tests should pass.
   
   ### Was this patch authored or co-authored using generative AI tooling?
   
   No.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-53359][PYTHON] Fix Arrow UDTF to handle the results as iterator [spark]

Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon closed pull request #52104: [SPARK-53359][PYTHON] Fix Arrow UDTF to handle the results as iterator
URL: https://github.com/apache/spark/pull/52104


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-53359][PYTHON] Fix Arrow UDTF to handle the results as iterator [spark]

Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #52104:
URL: https://github.com/apache/spark/pull/52104#issuecomment-3218454588

   Merged to master.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-53359][PYTHON] Fix Arrow UDTF to handle the results as iterator [spark]

Posted by "allisonwang-db (via GitHub)" <gi...@apache.org>.
allisonwang-db commented on code in PR #52104:
URL: https://github.com/apache/spark/pull/52104#discussion_r2294917510


##########
python/pyspark/worker.py:
##########
@@ -2029,10 +2006,8 @@ def check_return_value(res):
                     if check_output_row_against_schema is not None:

Review Comment:
   Let's also remove this block? It's not performant and not really needed to check against the row schema



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org