You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "Geser Dugarov (Jira)" <ji...@apache.org> on 2024/02/27 07:17:00 UTC
[jira] [Comment Edited] (HUDI-5762) Unify Config Types
[ https://issues.apache.org/jira/browse/HUDI-5762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17821003#comment-17821003 ]
Geser Dugarov edited comment on HUDI-5762 at 2/27/24 7:16 AM:
--------------------------------------------------------------
[~jonvex], [~guoyihua], [~pwason], [~shivnarayan],
Do we really need to unify config types? It is not right as mentioned in the description that nearly all config are strings.
I've looked at commit d0929341d0ad25b3ce587d7f229d2fcdf7796768, Feb 26, 2024.
We have about 900 configuration parameters in Hudi, among them:
* string - 580 parameters,
* boolean - 139,
* integer - 121,
* long - 30,
* double - 12,
* float - 2,
* other - 13 (HoodieTableType, KafkaResetOffsetStrategies, etc.)
It looks that we should not transform parameters to string type.
was (Author: JIRAUSER301110):
[~jonvex], [~guoyihua],
Do we really need to unify config types? It is not right as mentioned in the description that nearly all config are strings.
I've looked at commit d0929341d0ad25b3ce587d7f229d2fcdf7796768, Feb 26, 2024.
We have about 900 configuration parameters in Hudi, among them:
* string - 580 parameters,
* boolean - 139,
* integer - 121,
* long - 30,
* double - 12,
* float - 2,
* other - 13 (HoodieTableType, KafkaResetOffsetStrategies, etc.)
It looks that we should not transform parameters to string type.
> Unify Config Types
> ------------------
>
> Key: HUDI-5762
> URL: https://issues.apache.org/jira/browse/HUDI-5762
> Project: Apache Hudi
> Issue Type: Improvement
> Components: configs
> Reporter: Jonathan Vexler
> Priority: Major
> Fix For: 1.1.0
>
>
> Nearly all configs are strings, but there are a few that use other classes or primitives. For example hoodie.schema.cache.enable is of type Boolean, while most boolean configs just take "true" or "false." Another example is hoodie.markers.timeline_server_based.batch.num_threads is of type Integer while most configs are again string
--
This message was sent by Atlassian Jira
(v8.20.10#820010)