You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org> on 2011/11/27 06:26:41 UTC

[jira] [Commented] (FLUME-821) Derby schema handler should create the necessary indexes for fast lookups.

    [ https://issues.apache.org/jira/browse/FLUME-821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13157663#comment-13157663 ] 

jiraposter@reviews.apache.org commented on FLUME-821:
-----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2938/
-----------------------------------------------------------

Review request for Flume and Prasad Mujumdar.


Summary
-------

This change introduces the ability to create indexes while schema creation via the derby schema handler. The implementation defaults to the creation of indexes which can be turned off via configuration. 


This addresses bug FLUME-821.
    https://issues.apache.org/jira/browse/FLUME-821


Diffs
-----

  flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/ConfigurationConstants.java 7e0b3ac 
  flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/impl/DerbySchemaHandler.java 7b29c7d 
  flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/impl/JdbcChannelProviderImpl.java c1bc400 
  flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/impl/MySQLSchemaHandler.java 1065ef9 
  flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/impl/SchemaHandler.java 68946c9 
  flume-ng-channels/flume-jdbc-channel/src/test/java/org/apache/flume/channel/jdbc/TestDerbySchemaHandlerQueries.java 9ce6d16 

Diff: https://reviews.apache.org/r/2938/diff


Testing
-------

All unit tests run successfully.


Thanks,

Arvind


                
> Derby schema handler should create the necessary indexes for fast lookups.
> --------------------------------------------------------------------------
>
>                 Key: FLUME-821
>                 URL: https://issues.apache.org/jira/browse/FLUME-821
>             Project: Flume
>          Issue Type: Improvement
>            Reporter: Arvind Prabhakar
>            Assignee: Arvind Prabhakar
>             Fix For: NG alpha 2
>
>         Attachments: FLUME-821-1.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira