[jira] [Closed] (JDO-824) JDOImplHelper.nonBinaryCompatibleMakeDirty() ignores Throwable

["Tilmann Zäschke (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/JDO-824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tilmann Zäschke closed JDO-824.
-------------------------------
    Resolution: Won't Fix

It is not clear why this was implemented.
However, changing this may break implementations.
This is undesirable, and since we don't know the original rationale for this catch-all, we chose to leave it be.

> JDOImplHelper.nonBinaryCompatibleMakeDirty() ignores Throwable
> --------------------------------------------------------------
>
>                 Key: JDO-824
>                 URL: https://issues.apache.org/jira/browse/JDO-824
>             Project: JDO
>          Issue Type: Task
>          Components: api
>    Affects Versions: JDO 3.2, JDO 3.2.1
>            Reporter: Tilmann Zäschke
>            Assignee: Tilmann Zäschke
>            Priority: Major
>
> The method JDOImplHelper.nonBinaryCompatibleMakeDirty() ignores all thrown Exceptions of type Throwable.
> This should probably be changed to be more specific, in the current state it would even ignore 
> OutOfMemoryException, which is probably not what is intended here.
> All occurrences:
> * nonBinaryCompatibleGet()
> * nonBinaryCompatibleIs()
> * nonBinaryCompatibleMakeDirty()
> Otherwise we should document why this okay.
> I am currently unsure why ignoring *any* exception is okay here?



--
This message was sent by Atlassian Jira
(v8.20.10#820010)