[GitHub] [spark] dilipbiswal commented on issue #24759: [SPARK-27395][SQL][WIP] Improve EXPLAIN command

[GitBox <gi...@apache.org>]

dilipbiswal commented on issue #24759: [SPARK-27395][SQL][WIP] Improve EXPLAIN command
URL: https://github.com/apache/spark/pull/24759#issuecomment-517353897
 
 
   @cloud-fan Thanks a lot for taking out the time for this PR.. Here are my responses.
   
   >the *(1) prefix is pretty short. Shall we keep this in the head portion? It can give you a general sense about how is your query being whole-stage-codegened. If you worry about the codegen id may conflict with the operator id, we can omit it and only use * as the prefix.
   
   Yeah.. we can do it. Let me give it a try to see how it looks.
   
   > it's a good idea to separate uncorrelated subqueries from the main query, but how about correlated subqueries? Can you give an example?
   
   Correlated subqueries will be in the form of Joins (semi, anti, leftouter etc). So it would look like normal join queries ? I will try a sample query and get you the output today.
   
   > Shall we always include the statistics?
   
   Do we have statistics in the physical plan nodes currently ? If so, we can include it in header portion of the plan along side each operator.
   
   > what's the general rule for each operator to display information? I think input always need to be included except the leaf node. What about others?
   
   For non-leaf operators, we can always print input and output as a default implementation and then each operator can override to include more details ? What do you think ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org