You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by di...@apache.org on 2004/06/24 20:32:53 UTC
cvs commit: jakarta-commons/dbcp/src/java/org/apache/commons/dbcp DriverManagerConnectionFactory.java
dirkv 2004/06/24 11:32:53
Modified: dbcp/src/java/org/apache/commons/dbcp
DriverManagerConnectionFactory.java
Log:
Bugzilla Bug 29791: DriverManagerConnectionFactory: blank username/password handling
- issue report & fix provided by Maxwell Grender-Jones
Revision Changes Path
1.9 +2 -2 jakarta-commons/dbcp/src/java/org/apache/commons/dbcp/DriverManagerConnectionFactory.java
Index: DriverManagerConnectionFactory.java
===================================================================
RCS file: /home/cvs/jakarta-commons/dbcp/src/java/org/apache/commons/dbcp/DriverManagerConnectionFactory.java,v
retrieving revision 1.8
retrieving revision 1.9
diff -u -r1.8 -r1.9
--- DriverManagerConnectionFactory.java 28 Feb 2004 12:18:17 -0000 1.8
+++ DriverManagerConnectionFactory.java 24 Jun 2004 18:32:53 -0000 1.9
@@ -42,7 +42,7 @@
public Connection createConnection() throws SQLException {
if(null == _props) {
- if((_uname == null) || (_passwd == null)) {
+ if((_uname == null) && (_passwd == null)) {
return DriverManager.getConnection(_connectUri);
} else {
return DriverManager.getConnection(_connectUri,_uname,_passwd);
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org