[GitHub] [hbase] bharathv commented on pull request #2769: HBASE-25032 Wait for region server to become online before adding it to online servers in Master

[GitBox <gi...@apache.org>]

bharathv commented on pull request #2769:
URL: https://github.com/apache/hbase/pull/2769#issuecomment-755028030


   Stumbled upon this one.
   
   >  Just a simple flag like initialized is enough? After we finish the initialization work, we set the flag to true, and regionServerReport will bring this flag to master, so master will know the region server is ready to take regions.
   
   Agree. I commented on the jira. I think this is an init sequence problem. If we break down the RPCs into the following, I think it should work.
   
   1. RPC to get RS startup Configuration from master, update the HRegionServer's conf.
   2. Do the usual init (current code in handleReportForDutyResponse()
   3. RPC to let master know RS is ready reportForDuty().
   
   Looks like that should fix the problem. Do this async stuff in master only complicates the master state machine.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org