You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/03/31 09:01:26 UTC
[GitHub] [tvm] domin1985 opened a new pull request #7775: [Relay][Parser] support dict attributes parsing
domin1985 opened a new pull request #7775:
URL: https://github.com/apache/tvm/pull/7775
Please review @jroesch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] altanh commented on pull request #7775: [Relay][Parser] support dict attributes parsing
Posted by GitBox <gi...@apache.org>.
altanh commented on pull request #7775:
URL: https://github.com/apache/tvm/pull/7775#issuecomment-817982175
I'm not super familiar with the interaction between parser and pretty printer, how come changing the printer solves the problem?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] jroesch commented on pull request #7775: [Relay][Parser] support dict attributes parsing
Posted by GitBox <gi...@apache.org>.
jroesch commented on pull request #7775:
URL: https://github.com/apache/tvm/pull/7775#issuecomment-819063199
cc @domin1985
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] domin1985 commented on pull request #7775: [Relay][Parser] support dict attributes parsing
Posted by GitBox <gi...@apache.org>.
domin1985 commented on pull request #7775:
URL: https://github.com/apache/tvm/pull/7775#issuecomment-824210250
> cc @domin1985
> I think this is an okay work around for now, ideally we could make the printing a little cleaner but I think the challenge is detecting between typed attributes. In which case are you using this functionality? operators should always have a registered type with them and normal calls shouldn't be using attributes.
Sorry for late reply. This patch is mainly for the sake of extended user defined Ops with DictAttr type. And the relay parser cannot reconstruct this attribute through model stream input generated by printer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] domin1985 edited a comment on pull request #7775: [Relay][Parser] support dict attributes parsing
Posted by GitBox <gi...@apache.org>.
domin1985 edited a comment on pull request #7775:
URL: https://github.com/apache/tvm/pull/7775#issuecomment-824210250
> cc @domin1985
> I think this is an okay work around for now, ideally we could make the printing a little cleaner but I think the challenge is detecting between typed attributes. In which case are you using this functionality? operators should always have a registered type with them and normal calls shouldn't be using attributes.
Sorry for late reply. This patch is mainly for extended user defined Ops with DictAttr type. Currently the relay parser cannot reconstruct this attribute through model stream input generated by printer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] jroesch commented on pull request #7775: [Relay][Parser] support dict attributes parsing
Posted by GitBox <gi...@apache.org>.
jroesch commented on pull request #7775:
URL: https://github.com/apache/tvm/pull/7775#issuecomment-819063149
I think this is an okay work around for now, ideally we could make the printing a little cleaner but I think the challenge is detecting between typed attributes. In which case are you using this functionality? operators should always have a registered type with them and normal calls shouldn't be using attributes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tqchen commented on pull request #7775: [Relay][Parser] support dict attributes parsing
Posted by GitBox <gi...@apache.org>.
tqchen commented on pull request #7775:
URL: https://github.com/apache/tvm/pull/7775#issuecomment-816649919
cc @MarisaKirisame @jroesch @altanh please help to review this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] masahi commented on pull request #7775: [Relay][Parser] support dict attributes parsing
Posted by GitBox <gi...@apache.org>.
masahi commented on pull request #7775:
URL: https://github.com/apache/tvm/pull/7775#issuecomment-1008434777
@domin1985 Can you update?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org