[GitHub] [incubator-devlake] likyh commented on a diff in pull request #4459: feat: add pipeline step for bitbucket

["likyh (via GitHub)" <gi...@apache.org>]

likyh commented on code in PR #4459:
URL: https://github.com/apache/incubator-devlake/pull/4459#discussion_r1111907363


##########
backend/plugins/bitbucket/models/deployment.go:
##########
@@ -23,21 +23,24 @@ import (
 )
 
 type BitbucketDeployment struct {
-	ConnectionId   uint64 `gorm:"primaryKey"`
-	BitbucketId    string `gorm:"primaryKey"`
-	PipelineId     string `gorm:"type:varchar(255)"`
-	Type           string `gorm:"type:varchar(255)"`
-	Name           string `gorm:"type:varchar(255)"`
-	Key            string `gorm:"type:varchar(255)"`
-	WebUrl         string `gorm:"type:varchar(255)"`
-	Status         string `gorm:"type:varchar(100)"`
-	StateUrl       string `gorm:"type:varchar(255)"`
-	CommitSha      string `gorm:"type:varchar(255)"`
-	CommitUrl      string `gorm:"type:varchar(255)"`
-	CreatedOn      *time.Time
-	StartedOn      *time.Time
-	CompletedOn    *time.Time
-	LastUpdateTime *time.Time
+	ConnectionId    uint64 `gorm:"primaryKey"`
+	BitbucketId     string `gorm:"primaryKey"`
+	PipelineId      string `gorm:"type:varchar(255)"`
+	StepId          string `gorm:"type:varchar(255)"`
+	Type            string `gorm:"type:varchar(255)"`
+	Name            string `gorm:"type:varchar(255)"`
+	Environment     string `gorm:"type:varchar(255)"`
+	EnvironmentType string `gorm:"type:varchar(255)"`

Review Comment:
   add StepId / Environment / EnvironmentType



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org