You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2020/03/08 05:12:09 UTC
[GitHub] [incubator-hudi] lamber-ken opened a new pull request #1387:
[HUDI-674] Rename hudi-hadoop-mr-bundle to hudi-hive-bundle
lamber-ken opened a new pull request #1387: [HUDI-674] Rename hudi-hadoop-mr-bundle to hudi-hive-bundle
URL: https://github.com/apache/incubator-hudi/pull/1387
## What is the purpose of the pull request
Mmore details, ge ahead with
https://lists.apache.org/thread.html/ra659be560374a9c2f39007e719bac11a8422e31f42769a49a757ea25%40%3Cdev.hudi.apache.org%3E
## Brief change log
- Rename `hudi-hadoop-mr-bundle` to `hudi-hive-bundle `
## Verify this pull request
Test steps: follow docker demo.
http://hudi.apache.org/docs/docker_demo.html
## Committer checklist
- [X] Has a corresponding JIRA in PR title & commit
- [X] Commit message is descriptive of the change
- [ ] CI is green
- [ ] Necessary doc changes done or have another open PR
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] codecov-io edited a comment on issue #1387:
[HUDI-674] Rename hudi-hadoop-mr-bundle to hudi-hive-bundle
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #1387: [HUDI-674] Rename hudi-hadoop-mr-bundle to hudi-hive-bundle
URL: https://github.com/apache/incubator-hudi/pull/1387#issuecomment-596169301
# [Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1387?src=pr&el=h1) Report
> Merging [#1387](https://codecov.io/gh/apache/incubator-hudi/pull/1387?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-hudi/commit/415882f9023795994e9cc8a8294909bbec7ab191?src=pr&el=desc) will **increase** coverage by `0.01%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-hudi/pull/1387?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1387 +/- ##
===========================================
+ Coverage 67.19% 67.2% +0.01%
Complexity 223 223
===========================================
Files 335 335
Lines 16279 16279
Branches 1661 1661
===========================================
+ Hits 10939 10941 +2
+ Misses 4604 4603 -1
+ Partials 736 735 -1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-hudi/pull/1387?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...n/java/org/apache/hudi/common/model/HoodieKey.java](https://codecov.io/gh/apache/incubator-hudi/pull/1387/diff?src=pr&el=tree#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUtleS5qYXZh) | `88.88% <0%> (-5.56%)` | `0% <0%> (ø)` | |
| [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://codecov.io/gh/apache/incubator-hudi/pull/1387/diff?src=pr&el=tree#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL2xvZy9Ib29kaWVMb2dGb3JtYXRXcml0ZXIuamF2YQ==) | `76.92% <0%> (+0.96%)` | `0% <0%> (ø)` | :arrow_down: |
| [...i/utilities/deltastreamer/HoodieDeltaStreamer.java](https://codecov.io/gh/apache/incubator-hudi/pull/1387/diff?src=pr&el=tree#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL2RlbHRhc3RyZWFtZXIvSG9vZGllRGVsdGFTdHJlYW1lci5qYXZh) | `80.8% <0%> (+1.01%)` | `8% <0%> (ø)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1387?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1387?src=pr&el=footer). Last update [415882f...074e845](https://codecov.io/gh/apache/incubator-hudi/pull/1387?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] codecov-io commented on issue #1387: [HUDI-674]
Rename hudi-hadoop-mr-bundle to hudi-hive-bundle
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #1387: [HUDI-674] Rename hudi-hadoop-mr-bundle to hudi-hive-bundle
URL: https://github.com/apache/incubator-hudi/pull/1387#issuecomment-596169301
# [Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1387?src=pr&el=h1) Report
> Merging [#1387](https://codecov.io/gh/apache/incubator-hudi/pull/1387?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-hudi/commit/415882f9023795994e9cc8a8294909bbec7ab191?src=pr&el=desc) will **increase** coverage by `0.01%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-hudi/pull/1387?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1387 +/- ##
===========================================
+ Coverage 67.19% 67.2% +0.01%
Complexity 223 223
===========================================
Files 335 335
Lines 16279 16279
Branches 1661 1661
===========================================
+ Hits 10939 10941 +2
+ Misses 4604 4603 -1
+ Partials 736 735 -1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-hudi/pull/1387?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...n/java/org/apache/hudi/common/model/HoodieKey.java](https://codecov.io/gh/apache/incubator-hudi/pull/1387/diff?src=pr&el=tree#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUtleS5qYXZh) | `88.88% <0%> (-5.56%)` | `0% <0%> (ø)` | |
| [...e/hudi/common/table/log/HoodieLogFormatWriter.java](https://codecov.io/gh/apache/incubator-hudi/pull/1387/diff?src=pr&el=tree#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL2xvZy9Ib29kaWVMb2dGb3JtYXRXcml0ZXIuamF2YQ==) | `76.92% <0%> (+0.96%)` | `0% <0%> (ø)` | :arrow_down: |
| [...i/utilities/deltastreamer/HoodieDeltaStreamer.java](https://codecov.io/gh/apache/incubator-hudi/pull/1387/diff?src=pr&el=tree#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL2RlbHRhc3RyZWFtZXIvSG9vZGllRGVsdGFTdHJlYW1lci5qYXZh) | `80.8% <0%> (+1.01%)` | `8% <0%> (ø)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1387?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1387?src=pr&el=footer). Last update [415882f...074e845](https://codecov.io/gh/apache/incubator-hudi/pull/1387?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] lamber-ken commented on issue #1387: [HUDI-674]
Rename hudi-hadoop-mr-bundle to hudi-hive-bundle
Posted by GitBox <gi...@apache.org>.
lamber-ken commented on issue #1387: [HUDI-674] Rename hudi-hadoop-mr-bundle to hudi-hive-bundle
URL: https://github.com/apache/incubator-hudi/pull/1387#issuecomment-596297205
Hi @bvaradar, reasonable. Keep it WIP untill next release version.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] vinothchandar commented on issue #1387: [HUDI-674]
Rename hudi-hadoop-mr-bundle to hudi-hive-bundle
Posted by GitBox <gi...@apache.org>.
vinothchandar commented on issue #1387: [HUDI-674] Rename hudi-hadoop-mr-bundle to hudi-hive-bundle
URL: https://github.com/apache/incubator-hudi/pull/1387#issuecomment-596225503
@bvaradar can you take a pass at this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] bvaradar commented on issue #1387: [HUDI-674]
Rename hudi-hadoop-mr-bundle to hudi-hive-bundle
Posted by GitBox <gi...@apache.org>.
bvaradar commented on issue #1387: [HUDI-674] Rename hudi-hadoop-mr-bundle to hudi-hive-bundle
URL: https://github.com/apache/incubator-hudi/pull/1387#issuecomment-596256048
I went through the relevant DISCUSS thread. @lamber-ken : I strongly feel we should at the least wait for next release for this change. I agree with changing hudi-hive to hudi-hive-sync. But changing hudi-hadoop-mr to hudi-hive in the same release would be very confusing to users who are using previous versions of hudi in production. Let me know your thoughts.
cc @vinothchandar
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] vinothchandar commented on issue #1387: [WIP]
[HUDI-674] Rename hudi-hadoop-mr-bundle to hudi-hive-bundle
Posted by GitBox <gi...@apache.org>.
vinothchandar commented on issue #1387: [WIP] [HUDI-674] Rename hudi-hadoop-mr-bundle to hudi-hive-bundle
URL: https://github.com/apache/incubator-hudi/pull/1387#issuecomment-596345639
@bvaradar Good call.. Did not think of this angle, that it might be confusing to have the same bundle name represent something totally different . lets delay this for a later release.
thanks @lamber-ken , as always!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] vinothchandar closed pull request #1387: [WIP] [HUDI-674] Rename hudi-hadoop-mr-bundle to hudi-hive-bundle
Posted by GitBox <gi...@apache.org>.
vinothchandar closed pull request #1387:
URL: https://github.com/apache/incubator-hudi/pull/1387
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org