You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "buraksenn (via GitHub)" <gi...@apache.org> on 2024/12/15 19:21:43 UTC

[PR] [minor] add missing slt tests for count(partitioned,aggregated, aggregated cube) [datafusion]

buraksenn opened a new pull request, #13790:
URL: https://github.com/apache/datafusion/pull/13790

   ## Which issue does this PR close?
   -
   
   ## Rationale for this change
   I saw TODO's in the codebase and they did not have any slt tests
   
   ## What changes are included in this PR?
   Several slt test cases for count(partitioned,aggregated, aggregated cube)
   
   ## Are these changes tested?
   They are only slt tests
   
   ## Are there any user-facing changes?
   No


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org

Re: [PR] [minor] add missing slt tests for count(partitioned,aggregated, aggregated cube) [datafusion]

Posted by "buraksenn (via GitHub)" <gi...@apache.org>.
buraksenn commented on PR #13790:
URL: https://github.com/apache/datafusion/pull/13790#issuecomment-2544115557

   > Thank you @buraksenn 🙏
   > 
   > You mention a TODO in the PR description. Should we also remove the TPDP?
   
   Thanks @alamb. I've already deleted them they are in the slt file actually


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org

Re: [PR] [minor] add missing slt tests for count(partitioned,aggregated, aggregated cube) [datafusion]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on code in PR #13790:
URL: https://github.com/apache/datafusion/pull/13790#discussion_r1885895765


##########
datafusion/sqllogictest/test_files/aggregate.slt:
##########
@@ -2179,11 +2179,62 @@ SELECT COUNT(c1), COUNT(c2) FROM test
 ----
 4 4
 
-# TODO: count_partitioned

Review Comment:
   Got it -- it is this 👍 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org

Re: [PR] [minor] add missing slt tests for count(partitioned,aggregated, aggregated cube) [datafusion]

Posted by "berkaysynnada (via GitHub)" <gi...@apache.org>.
berkaysynnada commented on PR #13790:
URL: https://github.com/apache/datafusion/pull/13790#issuecomment-2545073331

   LGTM, double-checked in postgre


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org

Re: [PR] [minor] add missing slt tests for count(partitioned,aggregated, aggregated cube) [datafusion]

Posted by "berkaysynnada (via GitHub)" <gi...@apache.org>.
berkaysynnada merged PR #13790:
URL: https://github.com/apache/datafusion/pull/13790


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org