You are viewing a plain text version of this content. The canonical link for it is here.
Posted to yarn-issues@hadoop.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2022/12/05 19:36:00 UTC
[jira] [Commented] (YARN-11388) Prevent resource leaks in TestClientRMService.
[ https://issues.apache.org/jira/browse/YARN-11388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17643526#comment-17643526 ]
ASF GitHub Bot commented on YARN-11388:
---------------------------------------
cnauroth opened a new pull request, #5187:
URL: https://github.com/apache/hadoop/pull/5187
### Description of PR
* Guarantee servers always get closed, even if a test throws an exception.
* Keep the generated `excludeFile` in a random test directory.
* Clean up most style and whitespace warnings.
### How was this patch tested?
Ran unit tests locally.
### For code changes:
- [X] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
- [ ] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE`, `LICENSE-binary`, `NOTICE-binary` files?
> Prevent resource leaks in TestClientRMService.
> ----------------------------------------------
>
> Key: YARN-11388
> URL: https://issues.apache.org/jira/browse/YARN-11388
> Project: Hadoop YARN
> Issue Type: Test
> Components: test
> Reporter: Chris Nauroth
> Assignee: Chris Nauroth
> Priority: Minor
>
> While working on YARN-11360, I noticed a few problems in {{TestClientRMService}} that made it difficult to work with. Tests do not guarantee that servers they start up get shutdown. If an individual test fails, then it can leave TCP sockets bound, causing subsequent tests in the suite to fail on their socket bind attempts for the same port. There is also a file generated by a test that is leaking outside of the build directory into the source tree.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org