You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "dao-jun (via GitHub)" <gi...@apache.org> on 2023/12/23 15:52:54 UTC
[PR] [improve] Use `CompositeByteBuf` to prevent memory copy. [rocketmq]
dao-jun opened a new pull request, #7694:
URL: https://github.com/apache/rocketmq/pull/7694
### Brief Description
Use `CompositeByteBuf` instead of `DirectByteBuf` to prevent memory copy.
### How Did You Test This Change?
Existing tests could cover the case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #7757] Use `CompositeByteBuf` to prevent memory copy. [rocketmq]
Posted by "RongtongJin (via GitHub)" <gi...@apache.org>.
RongtongJin merged PR #7694:
URL: https://github.com/apache/rocketmq/pull/7694
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [improve] Use `CompositeByteBuf` to prevent memory copy. [rocketmq]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #7694:
URL: https://github.com/apache/rocketmq/pull/7694#issuecomment-1868324074
## [Codecov](https://app.codecov.io/gh/apache/rocketmq/pull/7694?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
Attention: `1 lines` in your changes are missing coverage. Please review.
> Comparison is base [(`0d516ba`)](https://app.codecov.io/gh/apache/rocketmq/commit/0d516ba708b13aabf206fea2dd184fea1999fdd5?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 43.20% compared to head [(`44c1f72`)](https://app.codecov.io/gh/apache/rocketmq/pull/7694?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 43.22%.
> Report is 306 commits behind head on develop.
> :exclamation: Current head 44c1f72 differs from pull request most recent head 74277cf. Consider uploading reports for the commit 74277cf to get more accurate results
| [Files](https://app.codecov.io/gh/apache/rocketmq/pull/7694?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...che/rocketmq/remoting/netty/FileRegionEncoder.java](https://app.codecov.io/gh/apache/rocketmq/pull/7694?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cmVtb3Rpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3JlbW90aW5nL25ldHR5L0ZpbGVSZWdpb25FbmNvZGVyLmphdmE=) | 80.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/rocketmq/pull/7694?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## develop #7694 +/- ##
=============================================
+ Coverage 43.20% 43.22% +0.02%
- Complexity 9028 9811 +783
=============================================
Files 1107 1165 +58
Lines 78269 84491 +6222
Branches 10202 10970 +768
=============================================
+ Hits 33813 36523 +2710
- Misses 40222 43430 +3208
- Partials 4234 4538 +304
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/rocketmq/pull/7694?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org