[GitHub] [yunikorn-core] craigcondit commented on a diff in pull request #601: [YUNIKORN-1793] Handle placement rule and queue changes during initialisation

["craigcondit (via GitHub)" <gi...@apache.org>]

craigcondit commented on code in PR #601:
URL: https://github.com/apache/yunikorn-core/pull/601#discussion_r1287537709


##########
pkg/scheduler/objects/application.go:
##########
@@ -1875,9 +1875,6 @@ func (sa *Application) GetUser() security.UserGroup {
 // Get a tag from the application
 // Note: tags are not case sensitive
 func (sa *Application) GetTag(tag string) string {

Review Comment:
   Tags are currently immutable in the application. Therefore, access is safe. You are correct that if this changes in the future race conditions could result. However, that I think is out of scope here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org