You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@deltaspike.apache.org by Mark Struberg <st...@yahoo.de> on 2012/08/11 17:01:33 UTC

@SuppressWarning(unchecked) and likes

Hi!

Is it really necessary to have this suppress annotation in all of our sources? 
This stuff is most times even IDE specific, and I honestly see no reason for having it.

If someone doesn't like the warnings in some IDEs, then just disable it in your configuration.
But I see no reason for instead adding the suppression marker to each and every class. 

I'm all for +1 to remove it.
wdyt?

LieGrue,
strub

Re: @SuppressWarning(unchecked) and likes

Posted by Mark Struberg <st...@yahoo.de>.
The same goes for @SuppressWarnings("UnusedDeclaration")

Later versions of IDEs with better CDI support will be perfectly able to know that an @Inject field doesn't need to get set manually.
Same applies to producer methods and fields. We just ditch our capability to detect really unused fields or methods in later IDE versions.

LieGrue,
strub




----- Original Message -----
> From: Mark Struberg <st...@yahoo.de>
> To: deltaspike <de...@incubator.apache.org>
> Cc: 
> Sent: Saturday, August 11, 2012 5:01 PM
> Subject: @SuppressWarning(unchecked) and likes
> 
> Hi!
> 
> Is it really necessary to have this suppress annotation in all of our sources? 
> This stuff is most times even IDE specific, and I honestly see no reason for 
> having it.
> 
> If someone doesn't like the warnings in some IDEs, then just disable it in 
> your configuration.
> But I see no reason for instead adding the suppression marker to each and every 
> class. 
> 
> I'm all for +1 to remove it.
> wdyt?
> 
> LieGrue,
> strub
> 

Re: @SuppressWarning(unchecked) and likes

Posted by Romain Manni-Bucau <rm...@gmail.com>.
i hate them too

+1

- Romain


2012/8/11 Mark Struberg <st...@yahoo.de>

> Hi!
>
> Is it really necessary to have this suppress annotation in all of our
> sources?
> This stuff is most times even IDE specific, and I honestly see no reason
> for having it.
>
> If someone doesn't like the warnings in some IDEs, then just disable it in
> your configuration.
> But I see no reason for instead adding the suppression marker to each and
> every class.
>
> I'm all for +1 to remove it.
> wdyt?
>
> LieGrue,
> strub
>

Re: @SuppressWarning(unchecked) and likes

Posted by Gerhard Petracek <ge...@gmail.com>.
+0

regards,
gerhard



2012/8/12 Cody Lerum <co...@gmail.com>

> +0
>
> On Sat, Aug 11, 2012 at 6:36 PM, Jason Porter <li...@gmail.com>
> wrote:
> > +0
> >
> > On Sat, Aug 11, 2012 at 10:20 AM, Thomas Herzog <t.herzog@curecomp.com
> >wrote:
> >
> >> +1 from me
> >>
> >> -----Ursprüngliche Nachricht-----
> >> Von: Arne Limburg [mailto:arne.limburg@openknowledge.de]
> >> Gesendet: Samstag, 11. August 2012 18:18
> >> An: deltaspike-dev@incubator.apache.org; Mark Struberg
> >> Betreff: Re: @SuppressWarning(unchecked) and likes
> >>
> >> +1 from me, too
> >>
> >>
> >> Am 11.08.12 17:01 schrieb "Mark Struberg" unter <st...@yahoo.de>:
> >>
> >> >Hi!
> >> >
> >> >Is it really necessary to have this suppress annotation in all of our
> >> >sources?
> >> >This stuff is most times even IDE specific, and I honestly see no
> >> >reason for having it.
> >> >
> >> >If someone doesn't like the warnings in some IDEs, then just disable it
> >> >in your configuration.
> >> >But I see no reason for instead adding the suppression marker to each
> >> >and every class.
> >> >
> >> >I'm all for +1 to remove it.
> >> >wdyt?
> >> >
> >> >LieGrue,
> >> >strub
> >>
> >>
> >
> >
> > --
> > Jason Porter
> > http://lightguard-jp.blogspot.com
> > http://twitter.com/lightguardjp
> >
> > Software Engineer
> > Open Source Advocate
> > Author of Seam Catch - Next Generation Java Exception Handling
> >
> > PGP key id: 926CCFF5
> > PGP key available at: keyserver.net, pgp.mit.edu
>

Re: @SuppressWarning(unchecked) and likes

Posted by Cody Lerum <co...@gmail.com>.
+0

On Sat, Aug 11, 2012 at 6:36 PM, Jason Porter <li...@gmail.com> wrote:
> +0
>
> On Sat, Aug 11, 2012 at 10:20 AM, Thomas Herzog <t....@curecomp.com>wrote:
>
>> +1 from me
>>
>> -----Ursprüngliche Nachricht-----
>> Von: Arne Limburg [mailto:arne.limburg@openknowledge.de]
>> Gesendet: Samstag, 11. August 2012 18:18
>> An: deltaspike-dev@incubator.apache.org; Mark Struberg
>> Betreff: Re: @SuppressWarning(unchecked) and likes
>>
>> +1 from me, too
>>
>>
>> Am 11.08.12 17:01 schrieb "Mark Struberg" unter <st...@yahoo.de>:
>>
>> >Hi!
>> >
>> >Is it really necessary to have this suppress annotation in all of our
>> >sources?
>> >This stuff is most times even IDE specific, and I honestly see no
>> >reason for having it.
>> >
>> >If someone doesn't like the warnings in some IDEs, then just disable it
>> >in your configuration.
>> >But I see no reason for instead adding the suppression marker to each
>> >and every class.
>> >
>> >I'm all for +1 to remove it.
>> >wdyt?
>> >
>> >LieGrue,
>> >strub
>>
>>
>
>
> --
> Jason Porter
> http://lightguard-jp.blogspot.com
> http://twitter.com/lightguardjp
>
> Software Engineer
> Open Source Advocate
> Author of Seam Catch - Next Generation Java Exception Handling
>
> PGP key id: 926CCFF5
> PGP key available at: keyserver.net, pgp.mit.edu

Re: @SuppressWarning(unchecked) and likes

Posted by Jason Porter <li...@gmail.com>.
+0

On Sat, Aug 11, 2012 at 10:20 AM, Thomas Herzog <t....@curecomp.com>wrote:

> +1 from me
>
> -----Ursprüngliche Nachricht-----
> Von: Arne Limburg [mailto:arne.limburg@openknowledge.de]
> Gesendet: Samstag, 11. August 2012 18:18
> An: deltaspike-dev@incubator.apache.org; Mark Struberg
> Betreff: Re: @SuppressWarning(unchecked) and likes
>
> +1 from me, too
>
>
> Am 11.08.12 17:01 schrieb "Mark Struberg" unter <st...@yahoo.de>:
>
> >Hi!
> >
> >Is it really necessary to have this suppress annotation in all of our
> >sources?
> >This stuff is most times even IDE specific, and I honestly see no
> >reason for having it.
> >
> >If someone doesn't like the warnings in some IDEs, then just disable it
> >in your configuration.
> >But I see no reason for instead adding the suppression marker to each
> >and every class.
> >
> >I'm all for +1 to remove it.
> >wdyt?
> >
> >LieGrue,
> >strub
>
>


-- 
Jason Porter
http://lightguard-jp.blogspot.com
http://twitter.com/lightguardjp

Software Engineer
Open Source Advocate
Author of Seam Catch - Next Generation Java Exception Handling

PGP key id: 926CCFF5
PGP key available at: keyserver.net, pgp.mit.edu

AW: @SuppressWarning(unchecked) and likes

Posted by Thomas Herzog <t....@curecomp.com>.
+1 from me

-----Ursprüngliche Nachricht-----
Von: Arne Limburg [mailto:arne.limburg@openknowledge.de] 
Gesendet: Samstag, 11. August 2012 18:18
An: deltaspike-dev@incubator.apache.org; Mark Struberg
Betreff: Re: @SuppressWarning(unchecked) and likes

+1 from me, too


Am 11.08.12 17:01 schrieb "Mark Struberg" unter <st...@yahoo.de>:

>Hi!
>
>Is it really necessary to have this suppress annotation in all of our 
>sources?
>This stuff is most times even IDE specific, and I honestly see no 
>reason for having it.
>
>If someone doesn't like the warnings in some IDEs, then just disable it 
>in your configuration.
>But I see no reason for instead adding the suppression marker to each 
>and every class.
>
>I'm all for +1 to remove it.
>wdyt?
>
>LieGrue,
>strub


Re: @SuppressWarning(unchecked) and likes

Posted by Arne Limburg <ar...@openknowledge.de>.
+1 from me, too


Am 11.08.12 17:01 schrieb "Mark Struberg" unter <st...@yahoo.de>:

>Hi!
>
>Is it really necessary to have this suppress annotation in all of our
>sources? 
>This stuff is most times even IDE specific, and I honestly see no reason
>for having it.
>
>If someone doesn't like the warnings in some IDEs, then just disable it
>in your configuration.
>But I see no reason for instead adding the suppression marker to each and
>every class. 
>
>I'm all for +1 to remove it.
>wdyt?
>
>LieGrue,
>strub