[GitHub] [opennlp] rzo1 commented on a diff in pull request #492: OPENNLP-1448 - Introduce SLF4J in OpenNLP

["rzo1 (via GitHub)" <gi...@apache.org>]

rzo1 commented on code in PR #492:
URL: https://github.com/apache/opennlp/pull/492#discussion_r1087617892


##########
opennlp-dl/src/test/java/opennlp/dl/doccat/DocumentCategorizerDLEval.java:
##########
@@ -29,13 +29,17 @@
 import org.junit.jupiter.api.Assertions;
 import org.junit.jupiter.api.Disabled;
 import org.junit.jupiter.api.Test;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
 
 import opennlp.dl.AbstactDLTest;
 import opennlp.dl.InferenceOptions;
 import opennlp.dl.doccat.scoring.AverageClassificationScoringStrategy;
 
 public class DocumentCategorizerDLEval extends AbstactDLTest {
 
+  private static Logger logger = LoggerFactory.getLogger(DocumentCategorizerDLEval.class);

Review Comment:
   missing `final`



##########
opennlp-dl/src/main/java/opennlp/dl/doccat/DocumentCategorizerDL.java:
##########
@@ -51,6 +53,7 @@
  */
 public class DocumentCategorizerDL implements DocumentCategorizer {
 
+  private Logger logger = LoggerFactory.getLogger(DocumentCategorizerDL.class);

Review Comment:
   missing `static final`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@opennlp.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org