You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/01/28 06:37:19 UTC

[GitHub] [apisix] Firstsawyou commented on a change in pull request #2101: feat: customed config.yaml when apisix start

Firstsawyou commented on a change in pull request #2101:
URL: https://github.com/apache/apisix/pull/2101#discussion_r565843688



##########
File path: doc/architecture-design.md
##########
@@ -643,13 +645,13 @@ Enable advanced debug mode by modifying the configuration in `conf/debug.yaml` f
 
 The checker would judge whether the file data changed according to the last modification time of the file. If there has any change, reload it. If there was no change, skip this check. So it's hot reload for enabling or disabling advanced debug mode.
 
-|Key|Optional|Description|Default|
-|----|-----|---------|---|
-|hook_conf.enable|required|Enable/Disable hook debug trace. Target module function's input arguments or returned value would be printed once this option is enabled.|false|
-|hook_conf.name|required|The module list name of hook which has enabled debug trace||
-|hook_conf.log_level|required|Logging levels for input arguments & returned value|warn|
-|hook_conf.is_print_input_args|required|Enable/Disable input arguments print|true|
-|hook_conf.is_print_return_value|required|Enable/Disable returned value print|true|
+| Key                             | Optional | Description                                                                                                                               | Default |
+| ------------------------------- | -------- | ----------------------------------------------------------------------------------------------------------------------------------------- | ------- |
+| hook_conf.enable                | required | Enable/Disable hook debug trace. Target module function's input arguments or returned value would be printed once this option is enabled. | false   |
+| hook_conf.name                  | required | The module list name of hook which has enabled debug trace                                                                                |         |
+| hook_conf.log_level             | required | Logging levels for input arguments & returned value                                                                                       | warn    |
+| hook_conf.is_print_input_args   | required | Enable/Disable input arguments print                                                                                                      | true    |
+| hook_conf.is_print_return_value | required | Enable/Disable returned value print                                                                                                       | true    |

Review comment:
       I think it would be better to add `.` after the sentence in the `Description` field.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org