[jira] [Commented] (LIBCLOUD-839) ELB driver doesn't support IAM role temporary credentials

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LIBCLOUD-839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15389607#comment-15389607 ] 

ASF GitHub Bot commented on LIBCLOUD-839:
-----------------------------------------

GitHub user lrvan opened a pull request:

    https://github.com/apache/libcloud/pull/843

    [LIBCLOUD-839] IAM temporary credentials token support for ElasticLBDriver

    ## Connect to AWS ELB using IAM role temporary credentials
    
    ### Description
    
    Current implementation of ElasticLBDriver driver doesn't support token parameter which is required for authentication using IAM temporary credentials.
    
    Issue:
    https://issues.apache.org/jira/browse/LIBCLOUD-839
    
    ### Status
    
    done, ready for review
    
    ### Checklist (tick everything that applies)
    
    - [ ] [Code linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide) (required, can be done after the PR checks)
    - [ ] Documentation
    - [ ] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html)
    - [ ] [ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes) (required for bigger changes)
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/lrvan/libcloud LIBCLOUD-839_iam_token

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/libcloud/pull/843.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #843
    
----
commit 4fc9ccada7c456fe76ad21c785eccd0fd73bcbba
Author: Anton Kozyrev <an...@gmail.com>
Date:   2016-07-22T13:59:50Z

    [LIBCLOUD-839] added iam temp creds token support to ElasticLBDriver

----


> ELB driver doesn't support IAM role temporary credentials
> ---------------------------------------------------------
>
>                 Key: LIBCLOUD-839
>                 URL: https://issues.apache.org/jira/browse/LIBCLOUD-839
>             Project: Libcloud
>          Issue Type: Improvement
>          Components: LoadBalancer
>            Reporter: Anton Kozyrev
>            Priority: Minor
>
> Token parameter is not accepted by the driver:
> {code}
> class ElasticLBDriver(Driver):
>     name = 'Amazon Elastic Load Balancing'
>     website = 'http://aws.amazon.com/elasticloadbalancing/'
>     connectionCls = ELBConnection
>     signature_version = '4'
>     def __init__(self, access_id, secret, region):
>         super(ElasticLBDriver, self).__init__(access_id, secret)
>         self.region = region
>         self.region_name = region
>         self.connection.host = HOST % (region)
> {code}
> This way it's impossible to use temporary IAM role creds with AWS ELB driver.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)