You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/05/06 14:30:35 UTC

[GitHub] [incubator-nuttx-apps] anchao opened a new pull request #703: nshlib: Fix the build break in nsh_telnetd.c when CONFIG_NSH_CONSOLE=n

anchao opened a new pull request #703:
URL: https://github.com/apache/incubator-nuttx-apps/pull/703


   ## Summary
   
   nshlib: Fix the build break in nsh_telnetd.c when CONFIG_NSH_CONSOLE=n
   
   set the config:
   CONFIG_NSH_ROMFSETC=y
   CONFIG_NSH_CONSOLE=n
   
   nsh_telnetd.c: In function 'nsh_telnetstart':
   nsh_telnetd.c:267:22: error: 'vtbl' undeclared (first use in this function)
     267 |       nsh_initscript(vtbl);
         |                      ^~~~
   
   ## Impact
   
   CONFIG_NSH_ROMFSETC=y
   CONFIG_NSH_CONSOLE=n
   
   ## Testing
   
   ./tools/configure.sh -l photon:wlan


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 merged pull request #703: nshlib: Fix the build break in nsh_telnetd.c when CONFIG_NSH_CONSOLE=n

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #703:
URL: https://github.com/apache/incubator-nuttx-apps/pull/703


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a change in pull request #703: nshlib: Fix the build break in nsh_telnetd.c when CONFIG_NSH_CONSOLE=n

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #703:
URL: https://github.com/apache/incubator-nuttx-apps/pull/703#discussion_r627610133



##########
File path: nshlib/nsh_telnetd.c
##########
@@ -263,7 +266,9 @@ int nsh_telnetstart(sa_family_t family)
        */
 
 #if defined(CONFIG_NSH_ROMFSETC) && !defined(CONFIG_NSH_CONSOLE)
-      nsh_initscript(vtbl);
+      pstate = nsh_newconsole();
+      nsh_initscript(&pstate->cn_vtbl);
+      pstate->cn_vtbl.release(&pstate->cn_vtbl);

Review comment:
       change to nsh_release




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx-apps] anchao commented on pull request #703: nshlib: Fix the build break in nsh_telnetd.c when CONFIG_NSH_CONSOLE=n

Posted by GitBox <gi...@apache.org>.
anchao commented on pull request #703:
URL: https://github.com/apache/incubator-nuttx-apps/pull/703#issuecomment-833570478


   linked PR: https://github.com/apache/incubator-nuttx-apps/pull/586


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org