You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Aravindan Vijayan <av...@hortonworks.com> on 2017/02/07 01:01:31 UTC

Review Request 56357: AMBARI-19887:Add AMS and Grafana to PERF cluster

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56357/
-----------------------------------------------------------

Review request for Ambari, Alejandro Fernandez, Myroslav Papirkovskyy, Sumit Mohanty, Sid Wagle, and Vitalyi Brodetskyi.


Bugs: AMBARI-19887
    https://issues.apache.org/jira/browse/AMBARI-19887


Repository: ambari


Description
-------

The PERF cluster needs AMS + Grafana so we can triage ambari server performance issues by analyzing the metrics.

Sub-Tasks
1. Added AMS to PERF stack (inherited from common-services)
2. Modified FAKEZOOKEEPER metainfo.xml due to AMS dependency. Only service and component names are changed. No Zk install is done.
2. Modified before-ANY hook to support ams user and java.
3. Added metrics collector vip host & port support in Ambari Server metrics sink, since AMS may not be on an "actual" FQDN host.


Diffs
-----

  ambari-common/src/main/python/resource_management/libraries/functions/get_not_managed_resources.py 5f8bc67 
  ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/AmbariMetricSinkImpl.java 58d36c3 
  ambari-server/src/main/resources/stacks/PERF/1.0/hooks/before-ANY/scripts/hook.py 90e0266 
  ambari-server/src/main/resources/stacks/PERF/1.0/hooks/before-ANY/scripts/params.py PRE-CREATION 
  ambari-server/src/main/resources/stacks/PERF/1.0/hooks/before-ANY/scripts/shared_initialization.py PRE-CREATION 
  ambari-server/src/main/resources/stacks/PERF/1.0/hooks/before-START/scripts/hook.py c5600a3 
  ambari-server/src/main/resources/stacks/PERF/1.0/services/AMBARI_METRICS/configuration/ams-site.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/PERF/1.0/services/AMBARI_METRICS/metainfo.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/PERF/1.0/services/FAKEZOOKEEPER/alerts.json c30a53b1 
  ambari-server/src/main/resources/stacks/PERF/1.0/services/FAKEZOOKEEPER/kerberos.json c8c55b7 
  ambari-server/src/main/resources/stacks/PERF/1.0/services/FAKEZOOKEEPER/metainfo.xml 366ff6e 
  ambari-server/src/main/resources/stacks/PERF/1.0/services/FAKEZOOKEEPER/package/scripts/zookeeper_client.py 78cee4d 
  ambari-server/src/main/resources/stacks/PERF/1.0/services/FAKEZOOKEEPER/package/scripts/zookeeper_server.py 4373205 
  ambari-server/src/main/resources/stacks/PERF/1.0/services/stack_advisor.py PRE-CREATION 

Diff: https://reviews.apache.org/r/56357/diff/


Testing
-------

Manually tested.


Thanks,

Aravindan Vijayan


Re: Review Request 56357: AMBARI-19887:Add AMS and Grafana to PERF cluster

Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56357/#review164443
-----------------------------------------------------------


Ship it!




Ship It!

- Alejandro Fernandez


On Feb. 7, 2017, 1:01 a.m., Aravindan Vijayan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56357/
> -----------------------------------------------------------
> 
> (Updated Feb. 7, 2017, 1:01 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Myroslav Papirkovskyy, Sumit Mohanty, Sid Wagle, and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-19887
>     https://issues.apache.org/jira/browse/AMBARI-19887
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> The PERF cluster needs AMS + Grafana so we can triage ambari server performance issues by analyzing the metrics.
> 
> Sub-Tasks
> 1. Added AMS to PERF stack (inherited from common-services)
> 2. Modified FAKEZOOKEEPER metainfo.xml due to AMS dependency. Only service and component names are changed. No Zk install is done.
> 2. Modified before-ANY hook to support ams user and java.
> 3. Added metrics collector vip host & port support in Ambari Server metrics sink, since AMS may not be on an "actual" FQDN host.
> 
> 
> Diffs
> -----
> 
>   ambari-common/src/main/python/resource_management/libraries/functions/get_not_managed_resources.py 5f8bc67 
>   ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/AmbariMetricSinkImpl.java 58d36c3 
>   ambari-server/src/main/resources/stacks/PERF/1.0/hooks/before-ANY/scripts/hook.py 90e0266 
>   ambari-server/src/main/resources/stacks/PERF/1.0/hooks/before-ANY/scripts/params.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/PERF/1.0/hooks/before-ANY/scripts/shared_initialization.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/PERF/1.0/hooks/before-START/scripts/hook.py c5600a3 
>   ambari-server/src/main/resources/stacks/PERF/1.0/services/AMBARI_METRICS/configuration/ams-site.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/PERF/1.0/services/AMBARI_METRICS/metainfo.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/PERF/1.0/services/FAKEZOOKEEPER/alerts.json c30a53b1 
>   ambari-server/src/main/resources/stacks/PERF/1.0/services/FAKEZOOKEEPER/kerberos.json c8c55b7 
>   ambari-server/src/main/resources/stacks/PERF/1.0/services/FAKEZOOKEEPER/metainfo.xml 366ff6e 
>   ambari-server/src/main/resources/stacks/PERF/1.0/services/FAKEZOOKEEPER/package/scripts/zookeeper_client.py 78cee4d 
>   ambari-server/src/main/resources/stacks/PERF/1.0/services/FAKEZOOKEEPER/package/scripts/zookeeper_server.py 4373205 
>   ambari-server/src/main/resources/stacks/PERF/1.0/services/stack_advisor.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/56357/diff/
> 
> 
> Testing
> -------
> 
> Manually tested.
> 
> 
> Thanks,
> 
> Aravindan Vijayan
> 
>