[GitHub] [superset] kgabryje commented on a diff in pull request #22207: fix(explore): Value undefined and Unhashable type errors

[GitBox <gi...@apache.org>]

kgabryje commented on code in PR #22207:
URL: https://github.com/apache/superset/pull/22207#discussion_r1030720240


##########
superset-frontend/src/explore/components/ControlPanelsContainer.tsx:
##########
@@ -276,21 +277,36 @@ export const ControlPanelsContainer = (props: ControlPanelsContainerProps) => {
   >(state => state.explore.controlsTransferred);
 
   useEffect(() => {
+    const removeDatasourceWarningFromControl = (

Review Comment:
   We could, but that wouldn't bring much value I think since we won't use it in any other place. I guess it's a style preference



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org