[GitHub] [shardingsphere] FlyingZC opened a new issue, #27024: Support parsing Oracle CREATE DISKGROUP sql

["FlyingZC (via GitHub)" <gi...@apache.org>]

FlyingZC opened a new issue, #27024:
URL: https://github.com/apache/shardingsphere/issues/27024

   # Background
   Hi community,
   This issue is for #26878.
   
   ShardingSphere parser engine helps users parse a SQL to get the AST (Abstract Syntax Tree) and visit this tree to get SQLStatement (Java Object). Currently, we are planning to enhance the support for Oracle SQL parsing in ShardingSphere.
   
   More details:
   https://shardingsphere.apache.org/document/current/en/reference/sharding/parse/
   
   # Task
   This issue is to support more oracle sql parse, as follows:
   ```sql
   CREATE DISKGROUP data NORMAL REDUNDANCY
     FAILGROUP controller1 DISK
       '/devices/diska1' NAME diska1,
       '/devices/diska2' NAME diska2,
       '/devices/diska3' NAME diska3,
       '/devices/diska4' NAME diska4
     FAILGROUP controller2 DISK
       '/devices/diskb1' NAME diskb1,
       '/devices/diskb2' NAME diskb2,
       '/devices/diskb3' NAME diskb3,
       '/devices/diskb4' NAME diskb4
     ATTRIBUTE 'au_size'='4M',
       'compatible.asm' = '11.2', 
       'compatible.rdbms' = '11.2',
       'compatible.advm' = '11.2';
   ```
   
   ```sql
   CREATE FUNCTION Power_EqualsSpecific_Func(
     object PowerDemand_Typ, cell NUMBER, value NUMBER)
   RETURN NUMBER AS
     BEGIN
     IF cell <= object.CellDemandValues.LAST
     THEN
        IF (object.CellDemandValues(cell) = value) THEN
      RETURN 1;
        ELSE
      RETURN 0;
        END IF;
     ELSE
        RETURN NULL;
     END IF;
     END;
   ```
   
   ```sql
   CREATE FUNCTION Power_EqualsAny_Func(
     object PowerDemand_Typ, value NUMBER)
   RETURN NUMBER AS
      idx NUMBER;
     BEGIN
       FOR idx IN object.CellDemandValues.FIRST..object.CellDemandValues.LAST LOOP
         IF (object.CellDemandValues(idx) = value) THEN
      RETURN 1;
         END IF;
       END LOOP;
      RETURN 0;
     END;
   ```
   
   ```sql
   CREATE FUNCTION f(cur SYS_REFCURSOR, mgr_hiredate DATE) 
      RETURN NUMBER IS
      emp_hiredate DATE;
      before number :=0;
      after number:=0;
   begin
     loop
       fetch cur into emp_hiredate;
       exit when cur%NOTFOUND;
       if emp_hiredate > mgr_hiredate then
         after:=after+1;
       else
         before:=before+1;
       end if;
     end loop;
     close cur;
     if before > after then
       return 1;
     else
       return 0;
     end if;
   end;
   ```
   
   ```sql
   CREATE FUNCTION get_bal(acc_no IN NUMBER) 
      RETURN NUMBER 
      IS acc_bal NUMBER(11,2);
      BEGIN 
         SELECT order_total 
         INTO acc_bal 
         FROM orders 
         WHERE customer_id = acc_no; 
         RETURN(acc_bal); 
       END;
   ```
   
   # Process
   1. First confirm that this is a correct oracle sql syntax, if not please ignore;
   2. Compare SQL definitions in Oficial SQL Doc and ShardingSphere SQL Doc;
   3. If there is any difference in ShardingSphere SQL Doc, please correct them by referring to the Official SQL Doc;
   4. Run mvn install the current_file_module;
   5. Check whether there are any exceptions. If indeed, please fix them. (Especially xxxVisitor.class);
   6. Add new corresponding SQL case in SQL Cases and expected parsed result in Expected Statment XML;
   7. Run SQLParserParameterizedTest to make sure no exceptions.
   
   # Relevant Skills
   1. Master JAVA language
   2. Have a basic understanding of Antlr `g4` file
   3. Be familiar with Oracle SQLs


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] FlyingZC closed issue #27024: Support parsing Oracle CREATE DISKGROUP sql

["FlyingZC (via GitHub)" <gi...@apache.org>]

FlyingZC closed issue #27024: Support parsing Oracle CREATE DISKGROUP sql
URL: https://github.com/apache/shardingsphere/issues/27024


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org