[jira] [Commented] (BOOKKEEPER-174) Bookie can't start when replaying entries whose ledger were deleted and garbage collected.

["Ivan Kelly (Commented) (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BOOKKEEPER-174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13209575#comment-13209575 ] 

Ivan Kelly commented on BOOKKEEPER-174:
---------------------------------------

Fix looks good. I have a few cosmetic comments. 
a) isDebugEnabled isn't actually required here, since we use slf4j. We can just use the {} formatting mechanism. For example:
{code}
if (LOG.isDebugEnabled()) {
  LOG.debug("Skip replaying entries of ledger " + ledgerId + " since it was deleted.");
}
{code}
Can be written as 
{code}
LOG.debug("Skip replaying entries of ledger {} since it was deleted.", ledgerId);
{code}
Which is much neater.

b) I think you should add the tests into BookieJournalTest rather than creating a new suite.
                
> Bookie can't start when replaying entries whose ledger were deleted and garbage collected.
> ------------------------------------------------------------------------------------------
>
>                 Key: BOOKKEEPER-174
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-174
>             Project: Bookkeeper
>          Issue Type: Bug
>          Components: bookkeeper-server
>    Affects Versions: 4.0.0
>            Reporter: Sijie Guo
>            Assignee: Sijie Guo
>             Fix For: 4.1.0
>
>         Attachments: BOOKKEEPER-174.diff
>
>
> if a journal contains entries which the ledgers they belongs to has been deleted and garbage collected, replaying such journal would encounter NoSuchLedgerException. And the bookie can't start.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira