You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@datasketches.apache.org by GitBox <gi...@apache.org> on 2021/10/11 16:03:58 UTC

[GitHub] [datasketches-cpp] will-lauer opened a new pull request #245: Updating cmake config to support publication and package building

will-lauer opened a new pull request #245:
URL: https://github.com/apache/datasketches-cpp/pull/245


   A bunch of cmake changes to improve a bunch of things:
   
   - Add missing files
   - enable package building 
   - enable cmake structure to support importing with find_package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org

[GitHub] [datasketches-cpp] will-lauer commented on a change in pull request #245: Updating cmake config to support publication and package building

Posted by GitBox <gi...@apache.org>.
will-lauer commented on a change in pull request #245:
URL: https://github.com/apache/datasketches-cpp/pull/245#discussion_r738766207



##########
File path: README.md
##########
@@ -40,3 +38,62 @@ Building and running unit tests using cmake for Windows from the command line:
 	$ cmake --build build --config Release
 	$ cmake --build build --config Release --target RUN_TESTS
 ```
+
+To install a local distribution (OSX and Linux), use the following command. The
+CMAKE_INSTALL_PREFIX variable controls the destination. If not specified, it 
+defaults to installing in /usr (/usr/include, /usr/lib, etc). In the command below,
+the installation will be in /tmp/install/DataSketches (/tmp/install/DataSketches/include,
+/tmp/install/DataSketches/lib, etc)
+
+```
+	$ cmake -S . -B build/Release -DCMAKE_BUILD_TYPE=Release -DCMAKE_INSTALL_PREFIX=/tmp/install/DataSketches
+	$ cmake --build build/Release -t install
+```
+
+To generate an installable package using cmake's built in cpack packaging tool,
+use the following command. The type of packaging is controlled by the CPACK_GENERATOR
+variable (semi-colon separated list). Cmake usually supports packaging types such as RPM,
+DEB, STGZ, TGZ, TZ, ZIP, etc.
+
+```
+	$ cmake3 -S . -B build/Release -DCMAKE_BUILD_TYPE=Release -DCPACK_GENERATOR="RPM;STGZ;TGZ" 
+	$ cmake3 --build build/Release -t package
+```
+
+The DataSketches project can be included in other projects' CMakeLists.txt files in one of two ways.
+If DataSketches has been installed on the host (using an RPM, DEB, "make install" into /usr/local, or some 
+way, then CMake's `find_package` command can be used like this:
+
+```
+	find_package(DataSketches 3.2 REQUIRED)
+	target_link_library(my_dependent_target PUBLIC ${DATASKETCHES_LIB})
+```
+
+If you don't have DataSketches installed locally, dependent projects can pull it directly
+from GitHub using CMake's `ExternalProject` module. The code would look something like this:
+
+```
+	cmake_policy(SET CMP0097 NEW)
+	include(ExternalProject)
+	ExternalProject_Add(datasketches
+	    GIT_REPOSITORY https://github.com/apache/datasketches-cpp.git
+	    GIT_TAG 3.2.0
+	    GIT_SHALLOW true
+	    GIT_SUBMODULES ""
+	    INSTALL_DIR /tmp/datasketches-prefix
+	   	CMAKE_ARGS -DBUILD_TESTS=OFF -DCMAKE_BUILD_TYPE=${CMAKE_BUILD_TYPE} -DCMAKE_INSTALL_PREFIX=/tmp/datasketches-prefix
+
+		# Override the install command to add DESTDIR
+		# This is necessary to work around an oddity in the RPM (but not other) package
+		# generation, as CMake otherwise picks up the Datasketch files when building
+		# an RPM for a dependent package. (RPM scans the directory for files in addition to installing
+		# those files referenced in an "install" rule in the cmake file)
+	    INSTALL_COMMAND env DESTDIR= ${CMAKE_COMMAND} --build . --target install
+	)
+	ExternalProject_Get_property(datasketches INSTALL_DIR)
+	set(datasketches_INSTALL_DIR ${INSTALL_DIR})
+	message("Source dir of datasketches = ${datasketches_INSTALL_DIR}")
+	target_include_directories(my_dependent_target 
+								PRIVATE ${datasketches_INSTALL_DIR}/include/DataSketches)

Review comment:
       Looks like this spacing is because I use 4-space tabs in my editor. The file is a bit of a mix between tabs and spaces (and some of that is my fault), with tab seeming to be the default. It looks like git is showing the data using 8-space tabs, which makes it line up differently than in my editor.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org

[GitHub] [datasketches-cpp] AlexanderSaydakov merged pull request #245: Updating cmake config to support publication and package building

Posted by GitBox <gi...@apache.org>.
AlexanderSaydakov merged pull request #245:
URL: https://github.com/apache/datasketches-cpp/pull/245


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org

[GitHub] [datasketches-cpp] coveralls edited a comment on pull request #245: Updating cmake config to support publication and package building

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #245:
URL: https://github.com/apache/datasketches-cpp/pull/245#issuecomment-940223595


   ## Pull Request Test Coverage Report for [Build 1381917727](https://coveralls.io/builds/43753469)
   
   * **0** of **0**   changed or added relevant lines in **0** files are covered.
   * **7** unchanged lines in **3** files lost coverage.
   * Overall coverage remained the same at **92.769%**
   
   ---
   
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-----|--------------|--: |
   | [sampling/include/var_opt_sketch_impl.hpp](https://coveralls.io/builds/43753469/source?filename=sampling%2Finclude%2Fvar_opt_sketch_impl.hpp#L1737) | 1 | 5.77% |
   | [tuple/include/tuple_sketch_impl.hpp](https://coveralls.io/builds/43753469/source?filename=tuple%2Finclude%2Ftuple_sketch_impl.hpp#L246) | 2 | 9.36% |
   | [theta/include/theta_sketch_impl.hpp](https://coveralls.io/builds/43753469/source?filename=theta%2Finclude%2Ftheta_sketch_impl.hpp#L80) | 4 | 16.38% |
   <!-- | **Total:** | **7** |  | -->
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/43753469/badge)](https://coveralls.io/builds/43753469) |
   | :-- | --: |
   | Change from base [Build 1317592223](https://coveralls.io/builds/43351680): |  0.0% |
   | Covered Lines: | 2181 |
   | Relevant Lines: | 2351 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org

[GitHub] [datasketches-cpp] will-lauer commented on a change in pull request #245: Updating cmake config to support publication and package building

Posted by GitBox <gi...@apache.org>.
will-lauer commented on a change in pull request #245:
URL: https://github.com/apache/datasketches-cpp/pull/245#discussion_r738767217



##########
File path: README.md
##########
@@ -40,3 +38,62 @@ Building and running unit tests using cmake for Windows from the command line:
 	$ cmake --build build --config Release
 	$ cmake --build build --config Release --target RUN_TESTS
 ```
+
+To install a local distribution (OSX and Linux), use the following command. The
+CMAKE_INSTALL_PREFIX variable controls the destination. If not specified, it 
+defaults to installing in /usr (/usr/include, /usr/lib, etc). In the command below,
+the installation will be in /tmp/install/DataSketches (/tmp/install/DataSketches/include,
+/tmp/install/DataSketches/lib, etc)
+
+```
+	$ cmake -S . -B build/Release -DCMAKE_BUILD_TYPE=Release -DCMAKE_INSTALL_PREFIX=/tmp/install/DataSketches
+	$ cmake --build build/Release -t install
+```
+
+To generate an installable package using cmake's built in cpack packaging tool,
+use the following command. The type of packaging is controlled by the CPACK_GENERATOR
+variable (semi-colon separated list). Cmake usually supports packaging types such as RPM,
+DEB, STGZ, TGZ, TZ, ZIP, etc.
+
+```
+	$ cmake3 -S . -B build/Release -DCMAKE_BUILD_TYPE=Release -DCPACK_GENERATOR="RPM;STGZ;TGZ" 
+	$ cmake3 --build build/Release -t package
+```
+
+The DataSketches project can be included in other projects' CMakeLists.txt files in one of two ways.
+If DataSketches has been installed on the host (using an RPM, DEB, "make install" into /usr/local, or some 
+way, then CMake's `find_package` command can be used like this:
+
+```
+	find_package(DataSketches 3.2 REQUIRED)
+	target_link_library(my_dependent_target PUBLIC ${DATASKETCHES_LIB})

Review comment:
       Yes, a list of the environment variables is likely useful in the doc. In fact, it should probably be expanded to more than one, as both include directory, library, and target are useful.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org

[GitHub] [datasketches-cpp] coveralls edited a comment on pull request #245: Updating cmake config to support publication and package building

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #245:
URL: https://github.com/apache/datasketches-cpp/pull/245#issuecomment-940223595


   ## Pull Request Test Coverage Report for [Build 1355799137](https://coveralls.io/builds/43582740)
   
   * **0** of **0**   changed or added relevant lines in **0** files are covered.
   * No unchanged relevant lines lost coverage.
   * Overall coverage remained the same at **92.769%**
   
   ---
   
   
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/43582740/badge)](https://coveralls.io/builds/43582740) |
   | :-- | --: |
   | Change from base [Build 1317592223](https://coveralls.io/builds/43351680): |  0.0% |
   | Covered Lines: | 2181 |
   | Relevant Lines: | 2351 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org

[GitHub] [datasketches-cpp] will-lauer commented on pull request #245: Updating cmake config to support publication and package building

Posted by GitBox <gi...@apache.org>.
will-lauer commented on pull request #245:
URL: https://github.com/apache/datasketches-cpp/pull/245#issuecomment-954210186


   In response you @jmalkin's single directory comment, the files are named such that there are no collisons right now, but I suspect that restructuring the install image so that there is a toplevel datasketches directory that contains separate directories for each individual sketch type, plus a common directory, would be a better layout. Unfortunately, that has a fairly high impact, as it potentially changes the `#include` statements both in the code and in client code.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org

[GitHub] [datasketches-cpp] coveralls commented on pull request #245: Updating cmake config to support publication and package building

Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #245:
URL: https://github.com/apache/datasketches-cpp/pull/245#issuecomment-940223595


   ## Pull Request Test Coverage Report for [Build 1329710774](https://coveralls.io/builds/43418399)
   
   * **0** of **0**   changed or added relevant lines in **0** files are covered.
   * No unchanged relevant lines lost coverage.
   * Overall coverage remained the same at **92.769%**
   
   ---
   
   
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/43418399/badge)](https://coveralls.io/builds/43418399) |
   | :-- | --: |
   | Change from base [Build 1317592223](https://coveralls.io/builds/43351680): |  0.0% |
   | Covered Lines: | 2181 |
   | Relevant Lines: | 2351 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org

[GitHub] [datasketches-cpp] AlexanderSaydakov commented on a change in pull request #245: Updating cmake config to support publication and package building

Posted by GitBox <gi...@apache.org>.
AlexanderSaydakov commented on a change in pull request #245:
URL: https://github.com/apache/datasketches-cpp/pull/245#discussion_r738776297



##########
File path: README.md
##########
@@ -40,3 +38,62 @@ Building and running unit tests using cmake for Windows from the command line:
 	$ cmake --build build --config Release
 	$ cmake --build build --config Release --target RUN_TESTS
 ```
+
+To install a local distribution (OSX and Linux), use the following command. The
+CMAKE_INSTALL_PREFIX variable controls the destination. If not specified, it 
+defaults to installing in /usr (/usr/include, /usr/lib, etc). In the command below,
+the installation will be in /tmp/install/DataSketches (/tmp/install/DataSketches/include,
+/tmp/install/DataSketches/lib, etc)
+
+```
+	$ cmake -S . -B build/Release -DCMAKE_BUILD_TYPE=Release -DCMAKE_INSTALL_PREFIX=/tmp/install/DataSketches
+	$ cmake --build build/Release -t install
+```
+
+To generate an installable package using cmake's built in cpack packaging tool,
+use the following command. The type of packaging is controlled by the CPACK_GENERATOR
+variable (semi-colon separated list). Cmake usually supports packaging types such as RPM,
+DEB, STGZ, TGZ, TZ, ZIP, etc.
+
+```
+	$ cmake3 -S . -B build/Release -DCMAKE_BUILD_TYPE=Release -DCPACK_GENERATOR="RPM;STGZ;TGZ" 
+	$ cmake3 --build build/Release -t package
+```
+
+The DataSketches project can be included in other projects' CMakeLists.txt files in one of two ways.
+If DataSketches has been installed on the host (using an RPM, DEB, "make install" into /usr/local, or some 
+way, then CMake's `find_package` command can be used like this:
+
+```
+	find_package(DataSketches 3.2 REQUIRED)
+	target_link_library(my_dependent_target PUBLIC ${DATASKETCHES_LIB})
+```
+
+If you don't have DataSketches installed locally, dependent projects can pull it directly
+from GitHub using CMake's `ExternalProject` module. The code would look something like this:
+
+```
+	cmake_policy(SET CMP0097 NEW)
+	include(ExternalProject)
+	ExternalProject_Add(datasketches
+	    GIT_REPOSITORY https://github.com/apache/datasketches-cpp.git
+	    GIT_TAG 3.2.0
+	    GIT_SHALLOW true
+	    GIT_SUBMODULES ""
+	    INSTALL_DIR /tmp/datasketches-prefix
+	   	CMAKE_ARGS -DBUILD_TESTS=OFF -DCMAKE_BUILD_TYPE=${CMAKE_BUILD_TYPE} -DCMAKE_INSTALL_PREFIX=/tmp/datasketches-prefix
+
+		# Override the install command to add DESTDIR
+		# This is necessary to work around an oddity in the RPM (but not other) package
+		# generation, as CMake otherwise picks up the Datasketch files when building
+		# an RPM for a dependent package. (RPM scans the directory for files in addition to installing
+		# those files referenced in an "install" rule in the cmake file)
+	    INSTALL_COMMAND env DESTDIR= ${CMAKE_COMMAND} --build . --target install
+	)
+	ExternalProject_Get_property(datasketches INSTALL_DIR)
+	set(datasketches_INSTALL_DIR ${INSTALL_DIR})
+	message("Source dir of datasketches = ${datasketches_INSTALL_DIR}")
+	target_include_directories(my_dependent_target 
+								PRIVATE ${datasketches_INSTALL_DIR}/include/DataSketches)

Review comment:
       I would prefer spaces for consistency, but this is not critical




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org

[GitHub] [datasketches-cpp] jmalkin commented on a change in pull request #245: Updating cmake config to support publication and package building

Posted by GitBox <gi...@apache.org>.
jmalkin commented on a change in pull request #245:
URL: https://github.com/apache/datasketches-cpp/pull/245#discussion_r737896321



##########
File path: README.md
##########
@@ -40,3 +38,62 @@ Building and running unit tests using cmake for Windows from the command line:
 	$ cmake --build build --config Release
 	$ cmake --build build --config Release --target RUN_TESTS
 ```
+
+To install a local distribution (OSX and Linux), use the following command. The
+CMAKE_INSTALL_PREFIX variable controls the destination. If not specified, it 
+defaults to installing in /usr (/usr/include, /usr/lib, etc). In the command below,
+the installation will be in /tmp/install/DataSketches (/tmp/install/DataSketches/include,
+/tmp/install/DataSketches/lib, etc)
+
+```
+	$ cmake -S . -B build/Release -DCMAKE_BUILD_TYPE=Release -DCMAKE_INSTALL_PREFIX=/tmp/install/DataSketches
+	$ cmake --build build/Release -t install
+```
+
+To generate an installable package using cmake's built in cpack packaging tool,
+use the following command. The type of packaging is controlled by the CPACK_GENERATOR
+variable (semi-colon separated list). Cmake usually supports packaging types such as RPM,
+DEB, STGZ, TGZ, TZ, ZIP, etc.
+
+```
+	$ cmake3 -S . -B build/Release -DCMAKE_BUILD_TYPE=Release -DCPACK_GENERATOR="RPM;STGZ;TGZ" 
+	$ cmake3 --build build/Release -t package
+```
+
+The DataSketches project can be included in other projects' CMakeLists.txt files in one of two ways.
+If DataSketches has been installed on the host (using an RPM, DEB, "make install" into /usr/local, or some 
+way, then CMake's `find_package` command can be used like this:
+
+```
+	find_package(DataSketches 3.2 REQUIRED)
+	target_link_library(my_dependent_target PUBLIC ${DATASKETCHES_LIB})
+```
+
+If you don't have DataSketches installed locally, dependent projects can pull it directly
+from GitHub using CMake's `ExternalProject` module. The code would look something like this:
+
+```
+	cmake_policy(SET CMP0097 NEW)
+	include(ExternalProject)
+	ExternalProject_Add(datasketches
+	    GIT_REPOSITORY https://github.com/apache/datasketches-cpp.git
+	    GIT_TAG 3.2.0
+	    GIT_SHALLOW true
+	    GIT_SUBMODULES ""
+	    INSTALL_DIR /tmp/datasketches-prefix
+	   	CMAKE_ARGS -DBUILD_TESTS=OFF -DCMAKE_BUILD_TYPE=${CMAKE_BUILD_TYPE} -DCMAKE_INSTALL_PREFIX=/tmp/datasketches-prefix
+
+		# Override the install command to add DESTDIR
+		# This is necessary to work around an oddity in the RPM (but not other) package
+		# generation, as CMake otherwise picks up the Datasketch files when building
+		# an RPM for a dependent package. (RPM scans the directory for files in addition to installing
+		# those files referenced in an "install" rule in the cmake file)
+	    INSTALL_COMMAND env DESTDIR= ${CMAKE_COMMAND} --build . --target install
+	)
+	ExternalProject_Get_property(datasketches INSTALL_DIR)
+	set(datasketches_INSTALL_DIR ${INSTALL_DIR})
+	message("Source dir of datasketches = ${datasketches_INSTALL_DIR}")
+	target_include_directories(my_dependent_target 
+								PRIVATE ${datasketches_INSTALL_DIR}/include/DataSketches)

Review comment:
       PRIVATE seems to be spaced way over for some reason?

##########
File path: README.md
##########
@@ -40,3 +38,62 @@ Building and running unit tests using cmake for Windows from the command line:
 	$ cmake --build build --config Release
 	$ cmake --build build --config Release --target RUN_TESTS
 ```
+
+To install a local distribution (OSX and Linux), use the following command. The
+CMAKE_INSTALL_PREFIX variable controls the destination. If not specified, it 
+defaults to installing in /usr (/usr/include, /usr/lib, etc). In the command below,
+the installation will be in /tmp/install/DataSketches (/tmp/install/DataSketches/include,
+/tmp/install/DataSketches/lib, etc)
+
+```
+	$ cmake -S . -B build/Release -DCMAKE_BUILD_TYPE=Release -DCMAKE_INSTALL_PREFIX=/tmp/install/DataSketches
+	$ cmake --build build/Release -t install
+```
+
+To generate an installable package using cmake's built in cpack packaging tool,
+use the following command. The type of packaging is controlled by the CPACK_GENERATOR
+variable (semi-colon separated list). Cmake usually supports packaging types such as RPM,
+DEB, STGZ, TGZ, TZ, ZIP, etc.
+
+```
+	$ cmake3 -S . -B build/Release -DCMAKE_BUILD_TYPE=Release -DCPACK_GENERATOR="RPM;STGZ;TGZ" 
+	$ cmake3 --build build/Release -t package
+```
+
+The DataSketches project can be included in other projects' CMakeLists.txt files in one of two ways.
+If DataSketches has been installed on the host (using an RPM, DEB, "make install" into /usr/local, or some 
+way, then CMake's `find_package` command can be used like this:
+
+```
+	find_package(DataSketches 3.2 REQUIRED)
+	target_link_library(my_dependent_target PUBLIC ${DATASKETCHES_LIB})

Review comment:
       Should we provide the set (of size 1, I think?) of exported variables somewhere?
   
   I guess related, do we want to expose the individual sketches or just have people depend on the entire library? I think it'll only pull in relevant files since we're header-only.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org

[GitHub] [datasketches-cpp] coveralls edited a comment on pull request #245: Updating cmake config to support publication and package building

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #245:
URL: https://github.com/apache/datasketches-cpp/pull/245#issuecomment-940223595


   ## Pull Request Test Coverage Report for [Build 1356564860](https://coveralls.io/builds/43686519)
   
   * **0** of **0**   changed or added relevant lines in **0** files are covered.
   * No unchanged relevant lines lost coverage.
   * Overall coverage remained the same at **92.769%**
   
   ---
   
   
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/43686519/badge)](https://coveralls.io/builds/43686519) |
   | :-- | --: |
   | Change from base [Build 1317592223](https://coveralls.io/builds/43351680): |  0.0% |
   | Covered Lines: | 2181 |
   | Relevant Lines: | 2351 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org