You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@isis.apache.org by "Daniel Keir Haywood (Jira)" <ji...@apache.org> on 2021/02/28 13:28:00 UTC
[jira] [Updated] (ISIS-2552) Remove IsisConverterLocator if
possible, seems it is pretty limited and hopefully unnecessary
[ https://issues.apache.org/jira/browse/ISIS-2552?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daniel Keir Haywood updated ISIS-2552:
--------------------------------------
Description:
is IsisConverterLocator even used?
if (java.util.Date.class == correspondingClass) {
return _Casts.uncheckedCast(new DateConverterForJavaUtilDate(wicketViewerSettings, adjustBy));
}
if (java.sql.Date.class == correspondingClass) {
return _Casts.uncheckedCast(new DateConverterForJavaSqlDate(wicketViewerSettings, adjustBy));
}
if (org.joda.time.LocalDate.class == correspondingClass) {
return _Casts.uncheckedCast(new DateConverterForJodaLocalDate(wicketViewerSettings, adjustBy));
}
if (org.joda.time.LocalDateTime.class == correspondingClass) {
return _Casts.uncheckedCast(new DateConverterForJodaLocalDateTime(wicketViewerSettings, adjustBy));
}
if (org.joda.time.DateTime.class == correspondingClass) {
return _Casts.uncheckedCast(new DateConverterForJodaDateTime(wicketViewerSettings, adjustBy));
}
if (java.sql.Timestamp.class == correspondingClass) {
return _Casts.uncheckedCast(new DateConverterForJavaSqlTimestamp(wicketViewerSettings, adjustBy));
}
and compare to subclasses of ScalarPanelTextFieldDatePickerAbstract and calls to #getAdjustBy()
> Remove IsisConverterLocator if possible, seems it is pretty limited and hopefully unnecessary
> ---------------------------------------------------------------------------------------------
>
> Key: ISIS-2552
> URL: https://issues.apache.org/jira/browse/ISIS-2552
> Project: Isis
> Issue Type: Improvement
> Components: Isis Viewer Wicket
> Reporter: Daniel Keir Haywood
> Priority: Minor
>
> is IsisConverterLocator even used?
> if (java.util.Date.class == correspondingClass) {
> return _Casts.uncheckedCast(new DateConverterForJavaUtilDate(wicketViewerSettings, adjustBy));
> }
> if (java.sql.Date.class == correspondingClass) {
> return _Casts.uncheckedCast(new DateConverterForJavaSqlDate(wicketViewerSettings, adjustBy));
> }
> if (org.joda.time.LocalDate.class == correspondingClass) {
> return _Casts.uncheckedCast(new DateConverterForJodaLocalDate(wicketViewerSettings, adjustBy));
> }
> if (org.joda.time.LocalDateTime.class == correspondingClass) {
> return _Casts.uncheckedCast(new DateConverterForJodaLocalDateTime(wicketViewerSettings, adjustBy));
> }
> if (org.joda.time.DateTime.class == correspondingClass) {
> return _Casts.uncheckedCast(new DateConverterForJodaDateTime(wicketViewerSettings, adjustBy));
> }
> if (java.sql.Timestamp.class == correspondingClass) {
> return _Casts.uncheckedCast(new DateConverterForJavaSqlTimestamp(wicketViewerSettings, adjustBy));
> }
> and compare to subclasses of ScalarPanelTextFieldDatePickerAbstract and calls to #getAdjustBy()
--
This message was sent by Atlassian Jira
(v8.3.4#803005)