You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by anmolnar <gi...@git.apache.org> on 2018/10/02 13:56:47 UTC
[GitHub] zookeeper pull request #653: ZOOKEEPER-3159. Flaky: ClientRequestTimeoutTest...
GitHub user anmolnar opened a pull request:
https://github.com/apache/zookeeper/pull/653
ZOOKEEPER-3159. Flaky: ClientRequestTimeoutTest.testClientRequestTimeout
Can't see a reason why testing again the create method without packet drop. Timeout scenario has already been tested and this part seem to make the test flaky. Removed.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/anmolnar/zookeeper ZOOKEEPER-3159
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zookeeper/pull/653.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #653
----
commit 850bcdc8b9d88893901c5e3b53acf4488cf7bd8d
Author: Andor Molnar <an...@...>
Date: 2018-10-02T13:55:03Z
ZOOKEEPER-3159. Removed redundant assert block which usually failing
----
---
[GitHub] zookeeper issue #653: ZOOKEEPER-3159. Flaky: ClientRequestTimeoutTest.testCl...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit commented on the issue:
https://github.com/apache/zookeeper/pull/653
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2320/
---
[GitHub] zookeeper pull request #653: ZOOKEEPER-3159. Flaky: ClientRequestTimeoutTest...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zookeeper/pull/653
---
[GitHub] zookeeper issue #653: ZOOKEEPER-3159. Flaky: ClientRequestTimeoutTest.testCl...
Posted by anmolnar <gi...@git.apache.org>.
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/653
@hanm Are u happy with simplifying this test?
---
[GitHub] zookeeper issue #653: ZOOKEEPER-3159. Flaky: ClientRequestTimeoutTest.testCl...
Posted by anmolnar <gi...@git.apache.org>.
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/653
retest this please
---
[GitHub] zookeeper issue #653: ZOOKEEPER-3159. Flaky: ClientRequestTimeoutTest.testCl...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit commented on the issue:
https://github.com/apache/zookeeper/pull/653
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2381/
---
[GitHub] zookeeper issue #653: ZOOKEEPER-3159. Flaky: ClientRequestTimeoutTest.testCl...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit commented on the issue:
https://github.com/apache/zookeeper/pull/653
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2405/
---
[GitHub] zookeeper issue #653: ZOOKEEPER-3159. Flaky: ClientRequestTimeoutTest.testCl...
Posted by anmolnar <gi...@git.apache.org>.
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/653
This is committed too to 3.5 and master to reduce flaky test pressure.
---
[GitHub] zookeeper issue #653: ZOOKEEPER-3159. Flaky: ClientRequestTimeoutTest.testCl...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit commented on the issue:
https://github.com/apache/zookeeper/pull/653
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2421/
---
[GitHub] zookeeper issue #653: ZOOKEEPER-3159. Flaky: ClientRequestTimeoutTest.testCl...
Posted by anmolnar <gi...@git.apache.org>.
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/653
retest this please
---