You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@submarine.apache.org by GitBox <gi...@apache.org> on 2021/10/06 14:00:13 UTC

[GitHub] [submarine] MortalHappiness commented on a change in pull request #766: Submarine 1046 Remove package-lock.json in website

MortalHappiness commented on a change in pull request #766:
URL: https://github.com/apache/submarine/pull/766#discussion_r723306531



##########
File path: .github/workflows/deploy_website.yml
##########
@@ -66,10 +64,8 @@ jobs:
         run: |
           git config --global user.email "pingsutw@apache.org"
           git config --global user.name "pingsutw"
-          if [ -e yarn.lock ]; then
+          if [[ -e yarn.lock ]]; then
           yarn install --frozen-lockfile
-          elif [ -e package-lock.json ]; then
-          npm ci
           else
           npm i
           fi

Review comment:
       These lines should be changed to `run: yarn install --frozen-lockfile`.

##########
File path: .github/workflows/deploy_website.yml
##########
@@ -33,10 +33,8 @@ jobs:
       - name: Test Build
         working-directory: ./website
         run: |
-          if [ -e yarn.lock ]; then
+          if [[ -e yarn.lock ]]; then
           yarn install --frozen-lockfile
-          elif [ -e package-lock.json ]; then
-          npm ci
           else
           npm i
           fi

Review comment:
       These lines should be changed to `run: yarn install --frozen-lockfile`.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org