You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/12/12 10:57:08 UTC
[GitHub] [airflow] potiuk opened a new pull request #13033: Builds production image additionally from sdist and verifies it
potiuk opened a new pull request #13033:
URL: https://github.com/apache/airflow/pull/13033
This check is there to prevent problems similar to those reported
in #13027 and fixed in #13031
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #13033: Install airflow and providers from dist and verifies them
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #13033:
URL: https://github.com/apache/airflow/pull/13033#issuecomment-743797913
We can always disable those later - it's as easy as changing matrix to only include wheel now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on a change in pull request #13033: Install airflow and providers from dist and verifies them
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #13033:
URL: https://github.com/apache/airflow/pull/13033#discussion_r541591913
##########
File path: scripts/in_container/entrypoint_ci.sh
##########
@@ -103,7 +103,7 @@ if [[ -z ${INSTALL_AIRFLOW_VERSION=} ]]; then
export PYTHONPATH=${AIRFLOW_SOURCES}
elif [[ ${INSTALL_AIRFLOW_VERSION} == "none" ]]; then
echo
- echo "Skip installing airflow - only install wheel packages that are present locally"
+ echo "Skip installing airflow - only install wheel/tar,gz packages that are present locally"
Review comment:
```suggestion
echo "Skip installing airflow - only install wheel/tar.gz packages that are present locally"
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #13033: Install airflow and providers from dist and verifies them
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13033:
URL: https://github.com/apache/airflow/pull/13033#issuecomment-743796996
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #13033: Install airflow and providers from dist and verifies them
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #13033:
URL: https://github.com/apache/airflow/pull/13033
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #13033: Install airflow and providers from dist and verifies them
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #13033:
URL: https://github.com/apache/airflow/pull/13033#discussion_r541556370
##########
File path: Dockerfile
##########
@@ -255,7 +255,7 @@ RUN if [[ ${INSTALL_MYSQL_CLIENT} != "true" ]]; then \
pip install --user ${ADDITIONAL_PYTHON_DEPS} --constraint "${AIRFLOW_CONSTRAINTS_LOCATION}"; \
fi; \
if [[ ${INSTALL_FROM_DOCKER_CONTEXT_FILES} == "true" ]]; then \
- if ls /docker-context-files/*.whl 1> /dev/null 2>&1; then \
+ if ls /docker-context-files/*.{whl,tar.gz} 1> /dev/null 2>&1; then \
Review comment:
I also found out that I have sdist missing in ls check.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #13033: Install airflow and providers from dist and verifies them
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #13033:
URL: https://github.com/apache/airflow/pull/13033#discussion_r541558956
##########
File path: scripts/in_container/run_install_and_test_provider_packages.sh
##########
@@ -53,11 +53,20 @@ elif [[ ${INSTALL_AIRFLOW_VERSION} == "wheel" ]]; then
echo
uninstall_airflow_and_providers
install_airflow_from_wheel "[all]"
+ uninstall_providers
Review comment:
I also noticed that I did not uninstall providers here. It had no final effect before release (becuase it instlled rc1s first and then overwrote the installations with 1.0.0 versions built locally, but it is cleaner to remove the providers here
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #13033: Install airflow and providers from dist and verifies them
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #13033:
URL: https://github.com/apache/airflow/pull/13033#discussion_r541555983
##########
File path: scripts/ci/images/ci_verify_ci_image.sh
##########
@@ -52,4 +52,6 @@ function pull_ci_image() {
build_images::prepare_ci_build
+pull_ci_image
Review comment:
This is just to explicitly pull the image in separate pull command. I found out that I have not done that.
##########
File path: scripts/ci/images/ci_verify_prod_image.sh
##########
@@ -90,6 +90,8 @@ function pull_prod_image() {
build_images::prepare_prod_build
+pull_prod_image
Review comment:
Same here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org