You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Alexei Fedotov (JIRA)" <ji...@apache.org> on 2006/12/27 18:02:21 UTC
[jira] Created: (HARMONY-2906) [drlvm] applying code inspection
comments to compile.cpp
[drlvm] applying code inspection comments to compile.cpp
--------------------------------------------------------
Key: HARMONY-2906
URL: http://issues.apache.org/jira/browse/HARMONY-2906
Project: Harmony
Issue Type: Sub-task
Components: DRLVM
Reporter: Alexei Fedotov
The patch extracts a beautification part of the fix of HARMONY-2528 [drlvm] VM crashes instead of throwing AbstractMethodError. The patch is important because a simple solution of HARMONY-2528 is possible after the patch is applied.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HARMONY-2906) [drlvm] applying code inspection
comments to compile.cpp
Posted by "Alexei Fedotov (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-2906?page=all ]
Alexei Fedotov updated HARMONY-2906:
------------------------------------
Attachment: code_inspection_compile_me_2.patch
Patch updated: removed outdated comment.
> [drlvm] applying code inspection comments to compile.cpp
> --------------------------------------------------------
>
> Key: HARMONY-2906
> URL: http://issues.apache.org/jira/browse/HARMONY-2906
> Project: Harmony
> Issue Type: Sub-task
> Components: DRLVM
> Reporter: Alexei Fedotov
> Attachments: code_inspection_compile_me.patch, code_inspection_compile_me.txt, code_inspection_compile_me_2.patch
>
>
> The patch extracts a beautification part of the fix of HARMONY-2528 [drlvm] VM crashes instead of throwing AbstractMethodError. The patch is important because a simple solution of HARMONY-2528 is possible after the patch is applied.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HARMONY-2906) [drlvm] applying code inspection
comments to compile.cpp
Posted by "Alexei Fedotov (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-2906?page=all ]
Alexei Fedotov updated HARMONY-2906:
------------------------------------
Attachment: code_inspection_compile_me_3.patch
[based on Gregory feedback] Slightly rearranged spaces in exception messages to make it possible to be Sun compliant in exception messages. Now the following code added right before
JIT_Result res = compile_do_compilation(method);
at the compile_me() function will produce a Sun-like exception message (no extra space).
+ if (method->is_abstract()) {
+ compile_raise_exception("java/lang/AbstractMethodError", "", method);
+ tmn_suspend_disable();
+ return NULL;
+ }
Gregory, if you think being compliant with Sun in exception messages is important, then please apply code_inspection_compile_me_3.patch, otherwise code_inspection_compile_me_2.patch is good enough.
> [drlvm] applying code inspection comments to compile.cpp
> --------------------------------------------------------
>
> Key: HARMONY-2906
> URL: http://issues.apache.org/jira/browse/HARMONY-2906
> Project: Harmony
> Issue Type: Sub-task
> Components: DRLVM
> Reporter: Alexei Fedotov
> Attachments: code_inspection_compile_me.patch, code_inspection_compile_me.txt, code_inspection_compile_me_2.patch, code_inspection_compile_me_3.patch
>
>
> The patch extracts a beautification part of the fix of HARMONY-2528 [drlvm] VM crashes instead of throwing AbstractMethodError. The patch is important because a simple solution of HARMONY-2528 is possible after the patch is applied.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Resolved: (HARMONY-2906) [drlvm] applying code inspection
comments to compile.cpp
Posted by "Gregory Shimansky (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-2906?page=all ]
Gregory Shimansky resolved HARMONY-2906.
----------------------------------------
Resolution: Fixed
I've applied the latest patch with one correction. In compile_IA32.cpp I had to change compile_jit_a_method to compile_me to make the code compile.
Patch applied at 490860. Please check that it was applied as expected.
> [drlvm] applying code inspection comments to compile.cpp
> --------------------------------------------------------
>
> Key: HARMONY-2906
> URL: http://issues.apache.org/jira/browse/HARMONY-2906
> Project: Harmony
> Issue Type: Sub-task
> Components: DRLVM
> Reporter: Alexei Fedotov
> Attachments: abstract_method_error_3.patch, code_inspection_compile_me.patch, code_inspection_compile_me.txt, code_inspection_compile_me_2.patch, code_inspection_compile_me_3.patch
>
>
> The patch extracts a beautification part of the fix of HARMONY-2528 [drlvm] VM crashes instead of throwing AbstractMethodError. The patch is important because a simple solution of HARMONY-2528 is possible after the patch is applied.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (HARMONY-2906) [drlvm] applying code inspection
comments to compile.cpp
Posted by "Alexei Fedotov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-2906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alexei Fedotov closed HARMONY-2906.
-----------------------------------
Gregory, thanks - the patch is applied as expected.
> [drlvm] applying code inspection comments to compile.cpp
> --------------------------------------------------------
>
> Key: HARMONY-2906
> URL: https://issues.apache.org/jira/browse/HARMONY-2906
> Project: Harmony
> Issue Type: Sub-task
> Components: DRLVM
> Reporter: Alexei Fedotov
> Attachments: abstract_method_error_3.patch, code_inspection_compile_me.patch, code_inspection_compile_me.txt, code_inspection_compile_me_2.patch, code_inspection_compile_me_3.patch
>
>
> The patch extracts a beautification part of the fix of HARMONY-2528 [drlvm] VM crashes instead of throwing AbstractMethodError. The patch is important because a simple solution of HARMONY-2528 is possible after the patch is applied.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-2906) [drlvm] applying code inspection
comments to compile.cpp
Posted by "Alexei Fedotov (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-2906?page=comments#action_12461093 ]
Alexei Fedotov commented on HARMONY-2906:
-----------------------------------------
All tests passed.
> [drlvm] applying code inspection comments to compile.cpp
> --------------------------------------------------------
>
> Key: HARMONY-2906
> URL: http://issues.apache.org/jira/browse/HARMONY-2906
> Project: Harmony
> Issue Type: Sub-task
> Components: DRLVM
> Reporter: Alexei Fedotov
> Attachments: code_inspection_compile_me.patch, code_inspection_compile_me.txt, code_inspection_compile_me_2.patch
>
>
> The patch extracts a beautification part of the fix of HARMONY-2528 [drlvm] VM crashes instead of throwing AbstractMethodError. The patch is important because a simple solution of HARMONY-2528 is possible after the patch is applied.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HARMONY-2906) [drlvm] applying code inspection
comments to compile.cpp
Posted by "Alexei Fedotov (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-2906?page=all ]
Alexei Fedotov updated HARMONY-2906:
------------------------------------
Attachment: code_inspection_compile_me.patch
Renamed patch extension. Testing.
> [drlvm] applying code inspection comments to compile.cpp
> --------------------------------------------------------
>
> Key: HARMONY-2906
> URL: http://issues.apache.org/jira/browse/HARMONY-2906
> Project: Harmony
> Issue Type: Sub-task
> Components: DRLVM
> Reporter: Alexei Fedotov
> Attachments: code_inspection_compile_me.patch, code_inspection_compile_me.txt
>
>
> The patch extracts a beautification part of the fix of HARMONY-2528 [drlvm] VM crashes instead of throwing AbstractMethodError. The patch is important because a simple solution of HARMONY-2528 is possible after the patch is applied.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HARMONY-2906) [drlvm] applying code inspection
comments to compile.cpp
Posted by "Alexei Fedotov (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-2906?page=all ]
Alexei Fedotov updated HARMONY-2906:
------------------------------------
Attachment: abstract_method_error_3.patch
Here is a patch for upgrading code_inspection_compile_me_3.patch to the fix of this bug
> [drlvm] applying code inspection comments to compile.cpp
> --------------------------------------------------------
>
> Key: HARMONY-2906
> URL: http://issues.apache.org/jira/browse/HARMONY-2906
> Project: Harmony
> Issue Type: Sub-task
> Components: DRLVM
> Reporter: Alexei Fedotov
> Attachments: abstract_method_error_3.patch, code_inspection_compile_me.patch, code_inspection_compile_me.txt, code_inspection_compile_me_2.patch, code_inspection_compile_me_3.patch
>
>
> The patch extracts a beautification part of the fix of HARMONY-2528 [drlvm] VM crashes instead of throwing AbstractMethodError. The patch is important because a simple solution of HARMONY-2528 is possible after the patch is applied.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HARMONY-2906) [drlvm] applying code inspection
comments to compile.cpp
Posted by "Alexei Fedotov (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-2906?page=all ]
Alexei Fedotov updated HARMONY-2906:
------------------------------------
Attachment: code_inspection_compile_me.txt
> [drlvm] applying code inspection comments to compile.cpp
> --------------------------------------------------------
>
> Key: HARMONY-2906
> URL: http://issues.apache.org/jira/browse/HARMONY-2906
> Project: Harmony
> Issue Type: Sub-task
> Components: DRLVM
> Reporter: Alexei Fedotov
> Attachments: code_inspection_compile_me.patch, code_inspection_compile_me.txt
>
>
> The patch extracts a beautification part of the fix of HARMONY-2528 [drlvm] VM crashes instead of throwing AbstractMethodError. The patch is important because a simple solution of HARMONY-2528 is possible after the patch is applied.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira