[GitHub] [druid] clintropolis commented on a change in pull request #10968: fix SQL issue for group by queries with time filter that gets optimized to false

[GitBox <gi...@apache.org>]

clintropolis commented on a change in pull request #10968:
URL: https://github.com/apache/druid/pull/10968#discussion_r590686700



##########
File path: sql/src/main/java/org/apache/druid/sql/calcite/filtration/CombineAndSimplifyBounds.java
##########
@@ -130,15 +134,24 @@ private static DimFilter doSimplify(final List<DimFilter> children, boolean disj
     // Group Bound filters by dimension, extractionFn, and comparator and compute a RangeSet for each one.
     final Map<BoundRefKey, List<BoundDimFilter>> bounds = new HashMap<>();
 
+    boolean allFalse = true;

Review comment:
       Hmm, the json creators have precondition checks that there is at least 1 field in an `AndDimFilter` or `OrDimFilter`, but some of the others do not, so I will change to 
   
   ```
   boolean allFalse = newChildren.size() > 0;
   ```
   
   or something similar




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org