You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/08/26 20:13:00 UTC
[jira] [Commented] (CB-11062) Cloning git repo when installing a
plugin doesn't fetch submodules
[ https://issues.apache.org/jira/browse/CB-11062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16593015#comment-16593015 ]
ASF GitHub Bot commented on CB-11062:
-------------------------------------
raphinesse closed pull request #424: CB-11062 Add --recursive option to git clone command
URL: https://github.com/apache/cordova-lib/pull/424
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/cordova-lib/src/gitclone.js b/cordova-lib/src/gitclone.js
index e3986753a..f176c1502 100644
--- a/cordova-lib/src/gitclone.js
+++ b/cordova-lib/src/gitclone.js
@@ -44,7 +44,7 @@ function clone(git_url, git_ref, clone_dir){
shell.rm('-rf', tmp_dir);
shell.mkdir('-p', tmp_dir);
- var cloneArgs = ['clone'];
+ var cloneArgs = ['clone', '--recursive'];
if(!needsGitCheckout) {
// only get depth of 1 if there is no branch/commit specified
cloneArgs.push('--depth=1');
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
> Cloning git repo when installing a plugin doesn't fetch submodules
> ------------------------------------------------------------------
>
> Key: CB-11062
> URL: https://issues.apache.org/jira/browse/CB-11062
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-lib, cordova-plugman
> Affects Versions: 6.1.1
> Reporter: Julian Frumar
> Priority: Major
> Labels: triaged
>
> When installing a plugin using a git repo as the id, e.g:
> {code}cordova plugin install https://github.com/path_to_git_repo.git{code}
> The plugman helper [gitclone.js|https://github.com/apache/cordova-lib/blob/master/cordova-lib%2Fsrc%2Fgitclone.js] doesn't retrieve using the *--recursive* option, so submodules are not fetched.
> This is breaking our plugin as cordova is failing to find all the necessary files as specified in the plugin.xml (some of them are from a nested git submodule repo)
> Relevant PR: https://github.com/apache/cordova-lib/pull/424
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org