[GitHub] [superset] nikolagigic commented on a change in pull request #12326: fix: control panel fields styling (#12236)

[GitBox <gi...@apache.org>]

nikolagigic commented on a change in pull request #12326:
URL: https://github.com/apache/superset/pull/12326#discussion_r553373600



##########
File path: superset-frontend/src/explore/components/OptionControls.tsx
##########
@@ -84,7 +84,7 @@ export const HeaderContainer = styled.div`
 export const LabelsContainer = styled.div`
   padding: ${({ theme }) => theme.gridUnit}px;
   border: solid 1px ${({ theme }) => theme.colors.grayscale.light2};
-  border-radius: 3px;
+  border-radius: 4px;

Review comment:
       Could we maybe use `gridUnit` here as well? As it will have the same result but keep it consistent with the rest of the styling?
   ```suggestion
     border-radius: ${({ theme }) => theme.gridUnit}px;
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org