You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@daffodil.apache.org by GitBox <gi...@apache.org> on 2021/03/10 03:34:25 UTC

[GitHub] [daffodil] jadams-tresys commented on pull request #473: Implement variable direction property

jadams-tresys commented on pull request #473:
URL: https://github.com/apache/daffodil/pull/473#issuecomment-794814073


   I reverted back to the original style of immediate creation/removal of NVI statements and only suspending when attempting to evaluate the expression.
   
   I added some commented out code for only allowing setVariable to be used during unparsing on variables without a default value.  This code causes several existing test cases to break (haven't checked against the various schema projects yet), so I wasn't sure if we wanted to go through with this change.  Maybe a warning about race conditions/potential undefined behavior would be a better approach?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org