You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2020/03/02 10:09:19 UTC

[GitHub] [incubator-echarts] karma2014 opened a new pull request #12217: feat(bar): in polar axis provide negative values. close #12109

karma2014 opened a new pull request #12217: feat(bar): in polar axis provide negative values. close #12109
URL: https://github.com/apache/incubator-echarts/pull/12217
 
 
   <!-- Please fill in the following information to help us review your PR more efficiently. -->
   
   ## Brief Information
   
   This pull request is in the type of:
   
   - [x] bug fixing
   - [ ] new feature
   - [ ] others
   
   
   
   ### What does this PR do?
   To support the bar chart in polar axis provide negative values, I hava found an example. In polar coordinate system, the option.radiusAxis.min not only negative values are not supported, but other values except 0 are also not supported, so this submission is to solve this problem.
   
   Here is the example' s option:
   ```
   option = {
       angleAxis: {
           type: 'category',
           data: ['S1', 'S2', 'S3']
       },
       radiusAxis: {
           min: 1,
           max: 6
       },
       polar: {
       },
       series: [{
           type: 'bar',
           data: [2, 2, 2],
           coordinateSystem: 'polar',
           itemStyle:{
               color:"blue"
               
           },
           name: 'A',
           stack: 'a'
       },
       {
           type: 'bar',
           data: [2, 2, 2],
           coordinateSystem: 'polar',
           name: 'B',
           stack: 'a'
       },
       {
           type: 'bar',
           data: [2, 2, 2],
           coordinateSystem: 'polar',
           name: 'C',
           stack: 'a'
       }],
       legend: {
           show: true,
           data: ['A', 'B', 'C']
       }
   };
   ```
   
   ### Fixed issues
   To fix the issue [12109](https://github.com/apache/incubator-echarts/issues/12109)
   <!--
   - #xxxx: ...
   -->
   
   
   ## Details
   
   ### Before: What was the problem?
   
   <!-- DESCRIBE THE BUG OR REQUIREMENT HERE. -->
   [12109](https://github.com/apache/incubator-echarts/issues/12109)
   
   <!-- ADD SCREENSHOT HERE IF APPLICABLE. -->
   
   ![image](https://user-images.githubusercontent.com/9964854/75661565-84c53800-5ca8-11ea-9e1d-e9dd4b06f64c.png)
   
   ### After: How is it fixed in this PR?
   
   <!-- THE RESULT AFTER FIXING AND A SIMPLE EXPLANATION ABOUT HOW IT IS FIXED. -->
   fix the the issue [12109](https://github.com/apache/incubator-echarts/issues/12109) and solve the radiusAxis.min do not support value except 0.
   
   <!-- ADD SCREENSHOT HERE IF APPLICABLE. -->
   
   ![image](https://user-images.githubusercontent.com/9964854/75665957-f2c12d80-5caf-11ea-9b7d-12db68d5a592.png)
   
   
   ## Usage
   
   ### Are there any API changes?
   
   - [ ] The API has been changed.
   
   <!-- LIST THE API CHANGES HERE -->
   
   
   
   ### Related test cases or examples to use the new APIs
   
   NA.
   
   
   
   ## Others
   
   ### Merging options
   
   - [ ] Please squash the commits into a single one when merge.
   
   ### Other information
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


[GitHub] [incubator-echarts] pissang commented on issue #12217: feat(bar): in polar axis provide negative values. close #12109

Posted by GitBox <gi...@apache.org>.
pissang commented on issue #12217: feat(bar): in polar axis provide negative values. close #12109
URL: https://github.com/apache/incubator-echarts/pull/12217#issuecomment-593366149
 
 
   Thanks for the contribution. Please don't commit distribution files

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


[GitHub] [incubator-echarts] echarts-bot[bot] commented on issue #12217: feat(bar): in polar axis provide negative values. close #12109

Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on issue #12217: feat(bar): in polar axis provide negative values. close #12109
URL: https://github.com/apache/incubator-echarts/pull/12217#issuecomment-593324258
 
 
   Thanks for your contribution!
   The community will review it ASAP. In the meanwhile, please checkout [the coding standard](https://echarts.apache.org/en/coding-standard.html) and Wiki about [How to make a pull request](https://github.com/apache/incubator-echarts/wiki/How-to-make-a-pull-request).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


[GitHub] [incubator-echarts] karma2014 commented on issue #12217: feat(bar): in polar axis provide negative values. close #12109

Posted by GitBox <gi...@apache.org>.
karma2014 commented on issue #12217: feat(bar): in polar axis provide negative values. close #12109
URL: https://github.com/apache/incubator-echarts/pull/12217#issuecomment-593944097
 
 
   close the pull request.I will Resubmit.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


[GitHub] [incubator-echarts] karma2014 closed pull request #12217: feat(bar): in polar axis provide negative values. close #12109

Posted by GitBox <gi...@apache.org>.
karma2014 closed pull request #12217: feat(bar): in polar axis provide negative values. close #12109
URL: https://github.com/apache/incubator-echarts/pull/12217
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org