You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Rajat Khandelwal <ra...@gmail.com> on 2016/03/01 08:18:18 UTC
Review Request 44201: HIVE-13188: Allow users of RetryingThriftClient
to close transport
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44201/
-----------------------------------------------------------
Review request for hive.
Bugs: HIVE-13188
https://issues.apache.org/jira/browse/HIVE-13188
Repository: hive-git
Description
-------
RetryingThriftCLIClient opens a TTransport and leaves it open. there should be a way to close that.
Diffs
-----
service/src/java/org/apache/hive/service/cli/thrift/RetryingThriftCLIServiceClient.java a81c600236e6e0f53a484806e559303279244616
service/src/test/org/apache/hive/service/cli/TestRetryingThriftCLIServiceClient.java 3798053a4a2e2b26b97b5accf96d73b58c89fb6e
Diff: https://reviews.apache.org/r/44201/diff/
Testing
-------
Thanks,
Rajat Khandelwal
Re: Review Request 44201: HIVE-13188: Allow users of
RetryingThriftClient to close transport
Posted by Rajat Khandelwal <ra...@gmail.com>.
> On March 1, 2016, 1:55 p.m., Amareshwari Sriramadasu wrote:
> > service/src/test/org/apache/hive/service/cli/TestRetryingThriftCLIServiceClient.java, line 61
> > <https://reviews.apache.org/r/44201/diff/1/?file=1275009#file1275009line61>
> >
> > Can you update test to call new method introduced?
Updated. Test is also passing
- Rajat
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44201/#review121407
-----------------------------------------------------------
On March 1, 2016, 12:48 p.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44201/
> -----------------------------------------------------------
>
> (Updated March 1, 2016, 12:48 p.m.)
>
>
> Review request for hive.
>
>
> Bugs: HIVE-13188
> https://issues.apache.org/jira/browse/HIVE-13188
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> RetryingThriftCLIClient opens a TTransport and leaves it open. there should be a way to close that.
>
>
> Diffs
> -----
>
> service/src/java/org/apache/hive/service/cli/thrift/RetryingThriftCLIServiceClient.java a81c600236e6e0f53a484806e559303279244616
> service/src/test/org/apache/hive/service/cli/TestRetryingThriftCLIServiceClient.java 3798053a4a2e2b26b97b5accf96d73b58c89fb6e
>
> Diff: https://reviews.apache.org/r/44201/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 44201: HIVE-13188: Allow users of
RetryingThriftClient to close transport
Posted by Rajat Khandelwal <ra...@gmail.com>.
> On March 1, 2016, 1:55 p.m., Amareshwari Sriramadasu wrote:
> > service/src/test/org/apache/hive/service/cli/TestRetryingThriftCLIServiceClient.java, line 61
> > <https://reviews.apache.org/r/44201/diff/1/?file=1275009#file1275009line61>
> >
> > Can you update test to call new method introduced?
>
> Rajat Khandelwal wrote:
> Updated. Test is also passing
>
> Amareshwari Sriramadasu wrote:
> Can you update by calling close Transport() as well ?
Added. But I can't assert whether the transport is closed after calling `closeTransport`. There is no `isClosed` method in transport, and calling `close` multiple times throws no errors.
- Rajat
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44201/#review121407
-----------------------------------------------------------
On March 3, 2016, 12:20 p.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44201/
> -----------------------------------------------------------
>
> (Updated March 3, 2016, 12:20 p.m.)
>
>
> Review request for hive.
>
>
> Bugs: HIVE-13188
> https://issues.apache.org/jira/browse/HIVE-13188
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> RetryingThriftCLIClient opens a TTransport and leaves it open. there should be a way to close that.
>
>
> Diffs
> -----
>
> service/src/java/org/apache/hive/service/cli/thrift/RetryingThriftCLIServiceClient.java a81c600236e6e0f53a484806e559303279244616
> service/src/test/org/apache/hive/service/cli/TestRetryingThriftCLIServiceClient.java 3798053a4a2e2b26b97b5accf96d73b58c89fb6e
>
> Diff: https://reviews.apache.org/r/44201/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 44201: HIVE-13188: Allow users of
RetryingThriftClient to close transport
Posted by Amareshwari Sriramadasu <am...@apache.org>.
> On March 1, 2016, 8:25 a.m., Amareshwari Sriramadasu wrote:
> > service/src/test/org/apache/hive/service/cli/TestRetryingThriftCLIServiceClient.java, line 61
> > <https://reviews.apache.org/r/44201/diff/1/?file=1275009#file1275009line61>
> >
> > Can you update test to call new method introduced?
>
> Rajat Khandelwal wrote:
> Updated. Test is also passing
Can you update by calling close Transport() as well ?
- Amareshwari
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44201/#review121407
-----------------------------------------------------------
On March 2, 2016, 6:07 a.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44201/
> -----------------------------------------------------------
>
> (Updated March 2, 2016, 6:07 a.m.)
>
>
> Review request for hive.
>
>
> Bugs: HIVE-13188
> https://issues.apache.org/jira/browse/HIVE-13188
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> RetryingThriftCLIClient opens a TTransport and leaves it open. there should be a way to close that.
>
>
> Diffs
> -----
>
> service/src/java/org/apache/hive/service/cli/thrift/RetryingThriftCLIServiceClient.java a81c600236e6e0f53a484806e559303279244616
> service/src/test/org/apache/hive/service/cli/TestRetryingThriftCLIServiceClient.java 3798053a4a2e2b26b97b5accf96d73b58c89fb6e
>
> Diff: https://reviews.apache.org/r/44201/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 44201: HIVE-13188: Allow users of
RetryingThriftClient to close transport
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44201/#review121407
-----------------------------------------------------------
service/src/test/org/apache/hive/service/cli/TestRetryingThriftCLIServiceClient.java (line 61)
<https://reviews.apache.org/r/44201/#comment183083>
Can you update test to call new method introduced?
- Amareshwari Sriramadasu
On March 1, 2016, 7:18 a.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44201/
> -----------------------------------------------------------
>
> (Updated March 1, 2016, 7:18 a.m.)
>
>
> Review request for hive.
>
>
> Bugs: HIVE-13188
> https://issues.apache.org/jira/browse/HIVE-13188
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> RetryingThriftCLIClient opens a TTransport and leaves it open. there should be a way to close that.
>
>
> Diffs
> -----
>
> service/src/java/org/apache/hive/service/cli/thrift/RetryingThriftCLIServiceClient.java a81c600236e6e0f53a484806e559303279244616
> service/src/test/org/apache/hive/service/cli/TestRetryingThriftCLIServiceClient.java 3798053a4a2e2b26b97b5accf96d73b58c89fb6e
>
> Diff: https://reviews.apache.org/r/44201/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 44201: HIVE-13188: Allow users of
RetryingThriftClient to close transport
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44201/#review121820
-----------------------------------------------------------
Ship it!
Ship It!
- Amareshwari Sriramadasu
On March 3, 2016, 6:50 a.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44201/
> -----------------------------------------------------------
>
> (Updated March 3, 2016, 6:50 a.m.)
>
>
> Review request for hive.
>
>
> Bugs: HIVE-13188
> https://issues.apache.org/jira/browse/HIVE-13188
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> RetryingThriftCLIClient opens a TTransport and leaves it open. there should be a way to close that.
>
>
> Diffs
> -----
>
> service/src/java/org/apache/hive/service/cli/thrift/RetryingThriftCLIServiceClient.java a81c600236e6e0f53a484806e559303279244616
> service/src/test/org/apache/hive/service/cli/TestRetryingThriftCLIServiceClient.java 3798053a4a2e2b26b97b5accf96d73b58c89fb6e
>
> Diff: https://reviews.apache.org/r/44201/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 44201: HIVE-13188: Allow users of
RetryingThriftClient to close transport
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44201/
-----------------------------------------------------------
(Updated March 3, 2016, 12:20 p.m.)
Review request for hive.
Bugs: HIVE-13188
https://issues.apache.org/jira/browse/HIVE-13188
Repository: hive-git
Description
-------
RetryingThriftCLIClient opens a TTransport and leaves it open. there should be a way to close that.
Diffs (updated)
-----
service/src/java/org/apache/hive/service/cli/thrift/RetryingThriftCLIServiceClient.java a81c600236e6e0f53a484806e559303279244616
service/src/test/org/apache/hive/service/cli/TestRetryingThriftCLIServiceClient.java 3798053a4a2e2b26b97b5accf96d73b58c89fb6e
Diff: https://reviews.apache.org/r/44201/diff/
Testing
-------
Thanks,
Rajat Khandelwal
Re: Review Request 44201: HIVE-13188: Allow users of
RetryingThriftClient to close transport
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44201/
-----------------------------------------------------------
(Updated March 2, 2016, 11:37 a.m.)
Review request for hive.
Bugs: HIVE-13188
https://issues.apache.org/jira/browse/HIVE-13188
Repository: hive-git
Description
-------
RetryingThriftCLIClient opens a TTransport and leaves it open. there should be a way to close that.
Diffs (updated)
-----
service/src/java/org/apache/hive/service/cli/thrift/RetryingThriftCLIServiceClient.java a81c600236e6e0f53a484806e559303279244616
service/src/test/org/apache/hive/service/cli/TestRetryingThriftCLIServiceClient.java 3798053a4a2e2b26b97b5accf96d73b58c89fb6e
Diff: https://reviews.apache.org/r/44201/diff/
Testing
-------
Thanks,
Rajat Khandelwal