You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@bahir.apache.org by GitBox <gi...@apache.org> on 2020/06/05 06:04:39 UTC

[GitHub] [bahir-flink] Git-Charles opened a new pull request #86: add zincrby command

Git-Charles opened a new pull request #86:
URL: https://github.com/apache/bahir-flink/pull/86


   add zincrby command


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [bahir-flink] eskabetxe commented on pull request #86: add zincrby command

Posted by GitBox <gi...@apache.org>.
eskabetxe commented on pull request #86:
URL: https://github.com/apache/bahir-flink/pull/86#issuecomment-662928954


   @Git-Charles can you squash all commits into one


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [bahir-flink] eskabetxe merged pull request #86: add zincrby command

Posted by GitBox <gi...@apache.org>.
eskabetxe merged pull request #86:
URL: https://github.com/apache/bahir-flink/pull/86


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [bahir-flink] eskabetxe edited a comment on pull request #86: add zincrby command

Posted by GitBox <gi...@apache.org>.
eskabetxe edited a comment on pull request #86:
URL: https://github.com/apache/bahir-flink/pull/86#issuecomment-662928954


   @Git-Charles thanks for your contribution


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [bahir-flink] eskabetxe commented on pull request #86: add zincrby command

Posted by GitBox <gi...@apache.org>.
eskabetxe commented on pull request #86:
URL: https://github.com/apache/bahir-flink/pull/86#issuecomment-657804610


   Thank you for the contribution :)
   Can you add some testing for this command?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [bahir-flink] Git-Charles commented on pull request #86: add zincrby command

Posted by GitBox <gi...@apache.org>.
Git-Charles commented on pull request #86:
URL: https://github.com/apache/bahir-flink/pull/86#issuecomment-657915649


   add zincrby command test case


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [bahir-flink] Git-Charles commented on pull request #86: add zincrby command

Posted by GitBox <gi...@apache.org>.
Git-Charles commented on pull request #86:
URL: https://github.com/apache/bahir-flink/pull/86#issuecomment-657913386


   I'd love to.
   
   
   lei_charles@163.com
    
   From: Joao Boto
   Date: 2020-07-14 05:33
   To: apache/bahir-flink
   CC: lei_charles; Author
   Subject: Re: [apache/bahir-flink] add zincrby command (#86)
   Thank you for the contribution :)
   Can you add some testing for this command?
   —
   You are receiving this because you authored the thread.
   Reply to this email directly, view it on GitHub, or unsubscribe.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org