[GitHub] [iceberg] harshm-dev commented on a diff in pull request #8385: Nessie: Provide better commit message on table registation #8331

["harshm-dev (via GitHub)" <gi...@apache.org>]

harshm-dev commented on code in PR #8385:
URL: https://github.com/apache/iceberg/pull/8385#discussion_r1318119184


##########
nessie/src/main/java/org/apache/iceberg/nessie/NessieIcebergClient.java:
##########
@@ -513,6 +513,8 @@ private String buildCommitMsg(TableMetadata base, TableMetadata metadata, String
           "Iceberg %s against %s", metadata.currentSnapshot().operation(), tableName);
     } else if (base != null && metadata.currentSchemaId() != base.currentSchemaId()) {
       return String.format("Iceberg schema change against %s", tableName);
+    } else if (base == null) {
+      return String.format("Iceberg table registered with name %s", tableName);

Review Comment:
   Thanks, changed the message likewise `created/registered instead of just registered`.
   
   > So, we can't differentiate create table and register flow?
   The nearest possibility is to consider the case as `create` if there are no snapshots in the new metadata. Since it may not always be true, not pursuing that path.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org