You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by "Neha Narkhede (JIRA)" <ji...@apache.org> on 2013/04/08 18:41:16 UTC

[jira] [Comment Edited] (KAFKA-852) Remove clientId from OffsetFetchResponse and OffsetCommitResponse

    [ https://issues.apache.org/jira/browse/KAFKA-852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13625515#comment-13625515 ] 

Neha Narkhede edited comment on KAFKA-852 at 4/8/13 4:40 PM:
-------------------------------------------------------------

Thanks for the patch, David. However, I'm not able to apply it using the following commands -

patch -p1 kafka-852.patch
patch -p0 kafka-852.patch


Please create a patch using the following command -

git diff <local-0.8-branch> > kafka-852.patch
OR
git remote update
git diff origin/0.8 > kafka-852.patch
                
      was (Author: nehanarkhede):
    Thanks for the patch, David. However, I'm not able to apply it using the following commands -

patch -p1 kafka-852.patch
patch -p0 kafka-852.patch


Please create a patch using the following command -

git diff <local-0.8-branch> > kafka-852.patch
                  
> Remove clientId from OffsetFetchResponse and OffsetCommitResponse
> -----------------------------------------------------------------
>
>                 Key: KAFKA-852
>                 URL: https://issues.apache.org/jira/browse/KAFKA-852
>             Project: Kafka
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 0.8.1
>            Reporter: David Arthur
>            Assignee: David Arthur
>            Priority: Minor
>             Fix For: 0.8.1
>
>         Attachments: 0001-KAFKA-852-remove-clientId-from-Offset-Fetch-Commit-R.patch
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> These are not needed and conflict with the API documentation. Should be removed to be consistent with other APIs

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira