You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ofbiz.apache.org by jl...@apache.org on 2019/04/28 10:52:36 UTC
svn commit: r1858314 - in /ofbiz/ofbiz-plugins/branches/release17.12: ./
ecommerce/template/shoppinglist/EditShoppingList.ftl
Author: jleroux
Date: Sun Apr 28 10:52:36 2019
New Revision: 1858314
URL: http://svn.apache.org/viewvc?rev=1858314&view=rev
Log:
"Applied fix from plugins for revision: 1858312"
------------------------------------------------------------------------
r1858312 | jleroux | 2019-04-28 12:51:46 +0200 (dim. 28 avr. 2019) | 17 lignes
Fixed: Remove link is not working in shopping list
(OFBIZ-10967)
Steps to reproduce
1. Login with valid username and password.
2. Navigate to ecommerce.
2.1 Adds product/s to the cart
2.2 Add it/them in a shopping list.
4. Navigate to shopping list section.
5. Click on link “Remove"
Expected Result: Product should be removed from shopping list.
Actual Result: Remove link is not working.
jleroux: OFBIZ-7291 broke it. That can be tested on old demo (R13)
Fixed by using a simple submit field
Thanks: Ashish Sharma for report
------------------------------------------------------------------------
Modified:
ofbiz/ofbiz-plugins/branches/release17.12/ (props changed)
ofbiz/ofbiz-plugins/branches/release17.12/ecommerce/template/shoppinglist/EditShoppingList.ftl
Propchange: ofbiz/ofbiz-plugins/branches/release17.12/
------------------------------------------------------------------------------
--- svn:mergeinfo (original)
+++ svn:mergeinfo Sun Apr 28 10:52:36 2019
@@ -11,4 +11,4 @@
/ofbiz/branches/multitenant20100310/plugins:921280-927264
/ofbiz/branches/release13.07/plugins:1547657
/ofbiz/ofbiz-framework/trunk:1836107
-/ofbiz/ofbiz-plugins/trunk:1819576,1819580,1819582,1819589,1820962,1820973,1821045,1821049,1821051,1822129,1822133,1822139,1822143,1822145,1822389,1822391,1822395,1824646,1824648,1824650,1824654,1828569,1830856,1831084,1832727,1832800,1837796,1837845,1837857,1838249,1838381,1838816,1841650,1845558,1847272,1847346,1847398,1847528,1847530,1848009,1848396,1848398,1848921,1849119,1851002,1851068,1851135,1851185,1852988,1855082,1856802,1856917,1857120,1857173,1858141,1858244,1858285
+/ofbiz/ofbiz-plugins/trunk:1819576,1819580,1819582,1819589,1820962,1820973,1821045,1821049,1821051,1822129,1822133,1822139,1822143,1822145,1822389,1822391,1822395,1824646,1824648,1824650,1824654,1828569,1830856,1831084,1832727,1832800,1837796,1837845,1837857,1838249,1838381,1838816,1841650,1845558,1847272,1847346,1847398,1847528,1847530,1848009,1848396,1848398,1848921,1849119,1851002,1851068,1851135,1851185,1852988,1855082,1856802,1856917,1857120,1857173,1858141,1858244,1858285,1858312
Modified: ofbiz/ofbiz-plugins/branches/release17.12/ecommerce/template/shoppinglist/EditShoppingList.ftl
URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-plugins/branches/release17.12/ecommerce/template/shoppinglist/EditShoppingList.ftl?rev=1858314&r1=1858313&r2=1858314&view=diff
==============================================================================
--- ofbiz/ofbiz-plugins/branches/release17.12/ecommerce/template/shoppinglist/EditShoppingList.ftl (original)
+++ ofbiz/ofbiz-plugins/branches/release17.12/ecommerce/template/shoppinglist/EditShoppingList.ftl Sun Apr 28 10:52:36 2019
@@ -492,12 +492,12 @@ under the License.
<a href="javascript:TimestampSubmit(listform_${shoppingListItem.shoppingListItemSeqId});" class="btn btn-outline-secondary">${uiLabelMap.CommonUpdate}</a>
</div>
<div class="btn-group">
- <a href="javascript:document.removeFromShoppingList.submit();" class="btn btn-outline-secondary">${uiLabelMap.CommonRemove}</a>
+ <form name="removeFromShoppingList" method="post" action="<@o...@ofbizUrl>">
+ <input type="hidden" name="shoppingListId" value="${shoppingListItem.shoppingListId!}">
+ <input type="hidden" name="shoppingListItemSeqId" value="${shoppingListItem.shoppingListItemSeqId}">
+ <input type="submit" value="${uiLabelMap.CommonRemove}" class="btn btn-outline-secondary"/>
+ </form>
</div>
- <form name="removeFromShoppingList" method="post" action="<@o...@ofbizUrl>">
- <input type="hidden" name="shoppingListId" value="${shoppingListItem.shoppingListId!}">
- <input type="hidden" name="shoppingListItemSeqId" value="${shoppingListItem.shoppingListItemSeqId}">
- </form>
<#if isVirtual && productVariantAssocs?has_content>
<#assign replaceItemAction = "/replaceShoppingListItem/" + requestAttributes._CURRENT_VIEW_?if_exists />
<#assign addToCartAction = "/additem/" + requestAttributes._CURRENT_VIEW_?if_exists />