You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by Lisen Mu <im...@gmail.com> on 2013/07/26 09:32:31 UTC
Review Request 12960: DRILL-156: union pop
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12960/
-----------------------------------------------------------
Review request for drill.
Repository: drill-git
Description
-------
union pop.
Diffs
-----
sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/physical/base/AbstractMultiple.java PRE-CREATION
sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/physical/base/AbstractPhysicalVisitor.java f782325
sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/physical/base/PhysicalVisitor.java f36633f
sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/physical/config/Union.java PRE-CREATION
sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/ImplCreator.java 7740955
sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionBatchCreator.java PRE-CREATION
sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionRecordBatch.java PRE-CREATION
sandbox/prototype/exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/union/TestSimpleUnion.java PRE-CREATION
sandbox/prototype/exec/java-exec/src/test/resources/union/test1.json PRE-CREATION
Diff: https://reviews.apache.org/r/12960/diff/
Testing
-------
org.apache.drill.exec.physical.impl.union.TestSimpleUnion
Thanks,
Lisen Mu
Re: Review Request 12960: DRILL-156: union pop
Posted by Lisen Mu <im...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12960/
-----------------------------------------------------------
(Updated Aug. 20, 2013, 12:10 p.m.)
Review request for drill.
Changes
-------
Sorry for the late reply, I'd been pretty occupied for the last days.
I guess AbstractSingleRecordBatch is for single input? so I just go from AbstractRecordBatch?
Repository: drill-git
Description
-------
union pop.
Diffs (updated)
-----
sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/physical/base/AbstractMultiple.java PRE-CREATION
sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/physical/base/AbstractPhysicalVisitor.java 3b58803
sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/physical/base/PhysicalVisitor.java 8e09e3a
sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/physical/config/Union.java PRE-CREATION
sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/ImplCreator.java 2ce5c28
sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/ScreenCreator.java 9b31407
sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionBatchCreator.java PRE-CREATION
sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionRecordBatch.java PRE-CREATION
sandbox/prototype/exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/TestSimpleFragmentRun.java 6587237
sandbox/prototype/exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/filter/TestSimpleFilter.java afb0b3a
sandbox/prototype/exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/union/TestSimpleUnion.java PRE-CREATION
sandbox/prototype/exec/java-exec/src/test/resources/filter/test1.json 4f82145
sandbox/prototype/exec/java-exec/src/test/resources/union/test1.json PRE-CREATION
Diff: https://reviews.apache.org/r/12960/diff/
Testing
-------
org.apache.drill.exec.physical.impl.union.TestSimpleUnion
File Attachments
----------------
https://reviews.apache.org/media/uploaded/files/2013/07/30/DRILL-156.0002.patch.txt
Thanks,
Lisen Mu
Re: Review Request 12960: DRILL-156: union pop
Posted by Jacques Nadeau <ja...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12960/#review25230
-----------------------------------------------------------
Can you update this to utilize the new AbstractSingleRecordBatch and rebase off of master?
- Jacques Nadeau
On July 30, 2013, 2:44 a.m., Lisen Mu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12960/
> -----------------------------------------------------------
>
> (Updated July 30, 2013, 2:44 a.m.)
>
>
> Review request for drill.
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> union pop.
>
>
> Diffs
> -----
>
> sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionRecordBatch.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/12960/diff/
>
>
> Testing
> -------
>
> org.apache.drill.exec.physical.impl.union.TestSimpleUnion
>
>
> File Attachments
> ----------------
>
>
> https://reviews.apache.org/media/uploaded/files/2013/07/30/DRILL-156.0002.patch.txt
>
>
> Thanks,
>
> Lisen Mu
>
>
Re: Review Request 12960: DRILL-156: union pop
Posted by Lisen Mu <im...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12960/#review24203
-----------------------------------------------------------
- Lisen Mu
On July 30, 2013, 2:44 a.m., Lisen Mu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12960/
> -----------------------------------------------------------
>
> (Updated July 30, 2013, 2:44 a.m.)
>
>
> Review request for drill.
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> union pop.
>
>
> Diffs
> -----
>
> sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionRecordBatch.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/12960/diff/
>
>
> Testing
> -------
>
> org.apache.drill.exec.physical.impl.union.TestSimpleUnion
>
>
> File Attachments
> ----------------
>
>
> https://reviews.apache.org/media/uploaded/files/2013/07/30/DRILL-156.0002.patch.txt
>
>
> Thanks,
>
> Lisen Mu
>
>
Re: Review Request 12960: DRILL-156: union pop
Posted by Lisen Mu <im...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12960/
-----------------------------------------------------------
(Updated July 30, 2013, 2:44 a.m.)
Review request for drill.
Changes
-------
updated diff.
Repository: drill-git
Description
-------
union pop.
Diffs (updated)
-----
sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionRecordBatch.java PRE-CREATION
Diff: https://reviews.apache.org/r/12960/diff/
Testing
-------
org.apache.drill.exec.physical.impl.union.TestSimpleUnion
File Attachments
----------------
https://reviews.apache.org/media/uploaded/files/2013/07/30/DRILL-156.0002.patch.txt
Thanks,
Lisen Mu
Re: Review Request 12960: DRILL-156: union pop
Posted by Lisen Mu <im...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12960/
-----------------------------------------------------------
(Updated July 30, 2013, 2:41 a.m.)
Review request for drill.
Changes
-------
thanks for reviewing.
fixed about your comment
Repository: drill-git
Description
-------
union pop.
Diffs
-----
sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/physical/base/AbstractMultiple.java PRE-CREATION
sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/physical/base/AbstractPhysicalVisitor.java f782325
sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/physical/base/PhysicalVisitor.java f36633f
sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/physical/config/Union.java PRE-CREATION
sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/ImplCreator.java 7740955
sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionBatchCreator.java PRE-CREATION
sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionRecordBatch.java PRE-CREATION
sandbox/prototype/exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/union/TestSimpleUnion.java PRE-CREATION
sandbox/prototype/exec/java-exec/src/test/resources/union/test1.json PRE-CREATION
Diff: https://reviews.apache.org/r/12960/diff/
Testing
-------
org.apache.drill.exec.physical.impl.union.TestSimpleUnion
File Attachments (updated)
----------------
https://reviews.apache.org/media/uploaded/files/2013/07/30/DRILL-156.0002.patch.txt
Thanks,
Lisen Mu
Re: Review Request 12960: DRILL-156: union pop
Posted by Jacques Nadeau <ja...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12960/#review24198
-----------------------------------------------------------
Generally looks good. Two small comments. Nice work Lisen!
sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionRecordBatch.java
<https://reviews.apache.org/r/12960/#comment48037>
Isn't this a required condition? What is a union with no inputs?
sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionRecordBatch.java
<https://reviews.apache.org/r/12960/#comment48038>
You probably shouldn't call kill if you've already successfully completed a reading a stream of batches. E.g. maybe only curent and iterator.next() batches should be killed.
- Jacques Nadeau
On July 26, 2013, 7:32 a.m., Lisen Mu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12960/
> -----------------------------------------------------------
>
> (Updated July 26, 2013, 7:32 a.m.)
>
>
> Review request for drill.
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> union pop.
>
>
> Diffs
> -----
>
> sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/physical/base/AbstractMultiple.java PRE-CREATION
> sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/physical/base/AbstractPhysicalVisitor.java f782325
> sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/physical/base/PhysicalVisitor.java f36633f
> sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/physical/config/Union.java PRE-CREATION
> sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/ImplCreator.java 7740955
> sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionBatchCreator.java PRE-CREATION
> sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionRecordBatch.java PRE-CREATION
> sandbox/prototype/exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/union/TestSimpleUnion.java PRE-CREATION
> sandbox/prototype/exec/java-exec/src/test/resources/union/test1.json PRE-CREATION
>
> Diff: https://reviews.apache.org/r/12960/diff/
>
>
> Testing
> -------
>
> org.apache.drill.exec.physical.impl.union.TestSimpleUnion
>
>
> Thanks,
>
> Lisen Mu
>
>