You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2020/02/26 21:59:42 UTC
[GitHub] [lucene-solr] epugh opened a new pull request #1292: SOLR-14284 add
expressible support to list, and add example of removing a component
epugh opened a new pull request #1292: SOLR-14284 add expressible support to list, and add example of removing a component
URL: https://github.com/apache/lucene-solr/pull/1292
# Description
Add expressible to the list of config supported methods.
# Solution
updated docs.
# Tests
Locally built ref guide. I manually tested the commands.
# Checklist
Please review the following and check all that apply:
- [ X] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability.
- [ X] I have created a Jira issue and added the issue ID to my pull request title.
- [ X] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended)
- [ X] I have developed this patch against the `master` branch.
- [ ] I have run `ant precommit` and the appropriate test suite.
- [ ] I have added tests for my changes.
- [ X] I have added documentation for the [Ref Guide](https://github.com/apache/lucene-solr/tree/master/solr/solr-ref-guide) (for Solr changes only).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] epugh commented on issue #1292: SOLR-14284 add
expressible support to list, and add example of removing a component
Posted by GitBox <gi...@apache.org>.
epugh commented on issue #1292: SOLR-14284 add expressible support to list, and add example of removing a component
URL: https://github.com/apache/lucene-solr/pull/1292#issuecomment-604050263
Thank you!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] ctargett commented on issue #1292: SOLR-14284 add
expressible support to list, and add example of removing a component
Posted by GitBox <gi...@apache.org>.
ctargett commented on issue #1292: SOLR-14284 add expressible support to list, and add example of removing a component
URL: https://github.com/apache/lucene-solr/pull/1292#issuecomment-595237017
The changes here are slightly confusing because the descriptions of the Jira and the PR refer to documenting `add-expressible` (and etc.), but there are examples added for `delete-requesthandler`, which is tangential & sort of thrown in there. While the title of this PR mentions it, the descriptions don't so it's hard to know what to expect...it's fine in the end, it's just a barrier to a review to note for future PRs.
I left another specific comment on the new page, and generally that content is good. However, I know it will fail the build because there is no edit to a page to include the new page as a child of another (so it does not currently fit anywhere in the page hierarchy), which means you didn't run the build first and there could be other issues that need to be resolved before this can be committed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] epugh commented on issue #1292: SOLR-14284 add
expressible support to list, and add example of removing a component
Posted by GitBox <gi...@apache.org>.
epugh commented on issue #1292: SOLR-14284 add expressible support to list, and add example of removing a component
URL: https://github.com/apache/lucene-solr/pull/1292#issuecomment-595269969
Thanks @ctargett for the review. Do you want me to pull that `delete-requesthandler` into another Jira issue? Totally happy to do that, and your feedback makes complete sense about it being a barrier. I am looking at the other comments.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] ctargett commented on issue #1292: SOLR-14284 add
expressible support to list, and add example of removing a component
Posted by GitBox <gi...@apache.org>.
ctargett commented on issue #1292: SOLR-14284 add expressible support to list, and add example of removing a component
URL: https://github.com/apache/lucene-solr/pull/1292#issuecomment-595275870
It's fine to keep it here, it just was a disconnect at first.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] epugh commented on issue #1292: SOLR-14284 add
expressible support to list, and add example of removing a component
Posted by GitBox <gi...@apache.org>.
epugh commented on issue #1292: SOLR-14284 add expressible support to list, and add example of removing a component
URL: https://github.com/apache/lucene-solr/pull/1292#issuecomment-595290097
I think I have responded and pushed up all changes. Thank you for reviewing, and let me know if any other changes are needed!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] epugh commented on a change in pull request #1292:
SOLR-14284 add expressible support to list,
and add example of removing a component
Posted by GitBox <gi...@apache.org>.
epugh commented on a change in pull request #1292: SOLR-14284 add expressible support to list, and add example of removing a component
URL: https://github.com/apache/lucene-solr/pull/1292#discussion_r388354635
##########
File path: solr/solr-ref-guide/src/stream-api.adoc
##########
@@ -0,0 +1,210 @@
+= Stream Request Handler API
+:page-toclevels: 1
+:page-tocclass: right
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+
+These API commands work with the `/stream` request handler.
+
Review comment:
I reworked the intro, and used the `NOTE` to call out the lack of following v2 API structure. Also, there is a link from the Daemon expression detail to this page and vice versa, and I modified the `streaming-expressions.adoc` to have `stream-api.adoc` be a child page.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] epugh commented on issue #1292: SOLR-14284 add
expressible support to list, and add example of removing a component
Posted by GitBox <gi...@apache.org>.
epugh commented on issue #1292: SOLR-14284 add expressible support to list, and add example of removing a component
URL: https://github.com/apache/lucene-solr/pull/1292#issuecomment-602691390
@ctargett I wanted to follow up and see if you thought this was committable? I have a stack of PR's that I'm hoping to get dealt with ;-)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] ctargett commented on a change in pull request #1292:
SOLR-14284 add expressible support to list,
and add example of removing a component
Posted by GitBox <gi...@apache.org>.
ctargett commented on a change in pull request #1292: SOLR-14284 add expressible support to list, and add example of removing a component
URL: https://github.com/apache/lucene-solr/pull/1292#discussion_r388311699
##########
File path: solr/solr-ref-guide/src/stream-api.adoc
##########
@@ -0,0 +1,210 @@
+= Stream Request Handler API
+:page-toclevels: 1
+:page-tocclass: right
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+
+These API commands work with the `/stream` request handler.
+
Review comment:
Also, it seems that the v2 API structure is not supported with this API? If that's true, we might want to state that somewhere outright.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] ctargett merged pull request #1292: SOLR-14284 add
expressible support to list, and add example of removing a component
Posted by GitBox <gi...@apache.org>.
ctargett merged pull request #1292: SOLR-14284 add expressible support to list, and add example of removing a component
URL: https://github.com/apache/lucene-solr/pull/1292
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] ctargett commented on issue #1292: SOLR-14284 add
expressible support to list, and add example of removing a component
Posted by GitBox <gi...@apache.org>.
ctargett commented on issue #1292: SOLR-14284 add expressible support to list, and add example of removing a component
URL: https://github.com/apache/lucene-solr/pull/1292#issuecomment-604023492
Sorry, I've had a stack of things to deal with too. I only wanted to check it locally before merging but I was finally able to do that and merged it just now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] ctargett commented on a change in pull request #1292:
SOLR-14284 add expressible support to list,
and add example of removing a component
Posted by GitBox <gi...@apache.org>.
ctargett commented on a change in pull request #1292: SOLR-14284 add expressible support to list, and add example of removing a component
URL: https://github.com/apache/lucene-solr/pull/1292#discussion_r388300341
##########
File path: solr/solr-ref-guide/src/stream-api.adoc
##########
@@ -0,0 +1,210 @@
+= Stream Request Handler API
+:page-toclevels: 1
+:page-tocclass: right
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+
+These API commands work with the `/stream` request handler.
+
Review comment:
Since there are only really 2 types of actions possible - 1 to list all expressions available, and 4 to manipulate daemon streams - I think it might be helpful for users to state that somewhat limited scope upfront.
Also a link from the daemon expression to this new page would be appropriate IMO, and less importantly a link to the Stream handler documentation (unless this is intended to be a child of that page - not clear where this is intended to live).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org