You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@logging.apache.org by mi...@apache.org on 2016/08/27 11:50:19 UTC
[04/50] logging-log4j2 git commit: Add TODOs
Add TODOs
Project: http://git-wip-us.apache.org/repos/asf/logging-log4j2/repo
Commit: http://git-wip-us.apache.org/repos/asf/logging-log4j2/commit/b61f043d
Tree: http://git-wip-us.apache.org/repos/asf/logging-log4j2/tree/b61f043d
Diff: http://git-wip-us.apache.org/repos/asf/logging-log4j2/diff/b61f043d
Branch: refs/heads/master
Commit: b61f043d3ba7df7cdd6a1c3d2205bf2c7a520d7b
Parents: 9f3a7d6
Author: Mikael St�ldal <mi...@magine.com>
Authored: Sat Jun 18 23:34:22 2016 +0200
Committer: Mikael St�ldal <mi...@magine.com>
Committed: Sat Jun 18 23:34:22 2016 +0200
----------------------------------------------------------------------
.../src/main/scala/org/apache/logging/log4j/scala/Logger.scala | 4 ++--
.../src/main/scala/org/apache/logging/log4j/scala/Logger.scala | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/b61f043d/log4j-api-scala_2.10/src/main/scala/org/apache/logging/log4j/scala/Logger.scala
----------------------------------------------------------------------
diff --git a/log4j-api-scala_2.10/src/main/scala/org/apache/logging/log4j/scala/Logger.scala b/log4j-api-scala_2.10/src/main/scala/org/apache/logging/log4j/scala/Logger.scala
index ba15f8f..783073f 100644
--- a/log4j-api-scala_2.10/src/main/scala/org/apache/logging/log4j/scala/Logger.scala
+++ b/log4j-api-scala_2.10/src/main/scala/org/apache/logging/log4j/scala/Logger.scala
@@ -290,7 +290,7 @@ class Logger(val delegate: ExtendedLogger) {
def isEnabled(level: Level, marker: Marker): Boolean = delegate.isEnabled(level, marker)
-
+ // TODO fix FQCN for flow logging
def traceEntry(): EntryMessage = delegate.traceEntry()
def traceEntry(params: Any*): EntryMessage =
@@ -357,7 +357,7 @@ class Logger(val delegate: ExtendedLogger) {
}
private[scala] def traceEntryWithParams(params: Any*): EntryMessage = {
- delegate.traceEntry(null, params)
+ delegate.traceEntry(null, params) // TODO should not do ifEnabled check
}
}
http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/b61f043d/log4j-api-scala_2.11/src/main/scala/org/apache/logging/log4j/scala/Logger.scala
----------------------------------------------------------------------
diff --git a/log4j-api-scala_2.11/src/main/scala/org/apache/logging/log4j/scala/Logger.scala b/log4j-api-scala_2.11/src/main/scala/org/apache/logging/log4j/scala/Logger.scala
index ba15f8f..783073f 100644
--- a/log4j-api-scala_2.11/src/main/scala/org/apache/logging/log4j/scala/Logger.scala
+++ b/log4j-api-scala_2.11/src/main/scala/org/apache/logging/log4j/scala/Logger.scala
@@ -290,7 +290,7 @@ class Logger(val delegate: ExtendedLogger) {
def isEnabled(level: Level, marker: Marker): Boolean = delegate.isEnabled(level, marker)
-
+ // TODO fix FQCN for flow logging
def traceEntry(): EntryMessage = delegate.traceEntry()
def traceEntry(params: Any*): EntryMessage =
@@ -357,7 +357,7 @@ class Logger(val delegate: ExtendedLogger) {
}
private[scala] def traceEntryWithParams(params: Any*): EntryMessage = {
- delegate.traceEntry(null, params)
+ delegate.traceEntry(null, params) // TODO should not do ifEnabled check
}
}