[GitHub] [guacamole-client] necouchman commented on a change in pull request #348: GUACAMOLE-422: Forward Timezone to RDP and SSH Connections

[GitBox <gi...@apache.org>]

necouchman commented on a change in pull request #348: GUACAMOLE-422: Forward Timezone to RDP and SSH Connections
URL: https://github.com/apache/guacamole-client/pull/348#discussion_r278379277
 
 

 ##########
 File path: guacamole-common/src/main/java/org/apache/guacamole/protocol/ConfiguredGuacamoleSocket.java
 ##########
 @@ -142,6 +150,12 @@ public ConfiguredGuacamoleSocket(GuacamoleSocket socket,
 
             // Retrieve argument name
             String arg_name = arg_names.get(i);
+            
+            // Check for protocol version as first argument
+            if (i == 0 && arg_name.startsWith("VERSION_")) {
+                protocol = GuacamoleProtocolVersion.valueOf(arg_name);
+                arg_values[i] = protocol.toString();
 
 Review comment:
   Yeah, that could be a problem...should be fixed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services