svn commit: r1181405 - /hbase/branches/0.89/src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLog.java

[ns...@apache.org]

Author: nspiegelberg
Date: Tue Oct 11 02:05:48 2011
New Revision: 1181405

URL: http://svn.apache.org/viewvc?rev=1181405&view=rev
Log:
Additional Logging to Find Append Outliers

Summary:
minor additions:
1: enable debugging on DFSClient so we can see when new blocks are created
2: add the data length to append LOG.warn messages so we can see if it's only
large snapshots (ie: this might be too many array copies)

Test Plan:
mvn clean install -DskipTests

DiffCamp Revision: 171230
Reviewed By: kannan
CC: kannan
Tasks:
#416824: Hbase Outliers in Dark launch

Revert Plan:
OK

Modified:
    hbase/branches/0.89/src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLog.java

Modified: hbase/branches/0.89/src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLog.java
URL: http://svn.apache.org/viewvc/hbase/branches/0.89/src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLog.java?rev=1181405&r1=1181404&r2=1181405&view=diff
==============================================================================
--- hbase/branches/0.89/src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLog.java (original)
+++ hbase/branches/0.89/src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLog.java Tue Oct 11 02:05:48 2011
@@ -1053,8 +1053,13 @@ public class HLog implements Syncable {
       writeTime += took;
       writeOps++;
       if (took > 1000) {
-        LOG.warn(Thread.currentThread().getName() + " took " + took +
-          "ms appending an edit to hlog; editcount=" + this.numEntries.get());
+        long len = 0;
+        for(KeyValue kv : logEdit.getKeyValues()) {
+          len += kv.getLength();
+        }
+        LOG.warn(String.format(
+          "%s took %d ms appending an edit to hlog; editcount=%d, len~=%d",
+          Thread.currentThread().getName(), took, this.numEntries.get(), len));
       }
     } catch (IOException e) {
       LOG.fatal("Could not append. Requesting close of hlog", e);