You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@streampipes.apache.org by ri...@apache.org on 2022/07/07 21:09:37 UTC

[incubator-streampipes] branch dev updated: [STREAMPIPES-537] Remove obsolete configuration component

This is an automated email from the ASF dual-hosted git repository.

riemer pushed a commit to branch dev
in repository https://gitbox.apache.org/repos/asf/incubator-streampipes.git


The following commit(s) were added to refs/heads/dev by this push:
     new 28131f6bd [STREAMPIPES-537] Remove obsolete configuration component
28131f6bd is described below

commit 28131f6bdaf711df3f4d00d44d085c1d55c0909a
Author: Dominik Riemer <do...@gmail.com>
AuthorDate: Thu Jul 7 23:09:28 2022 +0200

    [STREAMPIPES-537] Remove obsolete configuration component
---
 .../app/configuration/configuration.component.css  | 22 -------
 .../app/configuration/configuration.component.html | 62 -----------------
 .../configuration/configuration.component.spec.ts  | 57 ----------------
 .../app/configuration/configuration.component.ts   | 47 -------------
 ui/src/app/configuration/configuration.module.ts   | 77 +++++++++++-----------
 5 files changed, 37 insertions(+), 228 deletions(-)

diff --git a/ui/src/app/configuration/configuration.component.css b/ui/src/app/configuration/configuration.component.css
deleted file mode 100644
index cd8f27327..000000000
--- a/ui/src/app/configuration/configuration.component.css
+++ /dev/null
@@ -1,22 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one or more
- * contributor license agreements.  See the NOTICE file distributed with
- * this work for additional information regarding copyright ownership.
- * The ASF licenses this file to You under the Apache License, Version 2.0
- * (the "License"); you may not use this file except in compliance with
- * the License.  You may obtain a copy of the License at
- *
- *    http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- *
- */
-
-.page-container-padding-inner {
-    padding: 10px;
-}
-
diff --git a/ui/src/app/configuration/configuration.component.html b/ui/src/app/configuration/configuration.component.html
deleted file mode 100644
index e1f287e73..000000000
--- a/ui/src/app/configuration/configuration.component.html
+++ /dev/null
@@ -1,62 +0,0 @@
-<!--
-  ~ Licensed to the Apache Software Foundation (ASF) under one or more
-  ~ contributor license agreements.  See the NOTICE file distributed with
-  ~ this work for additional information regarding copyright ownership.
-  ~ The ASF licenses this file to You under the Apache License, Version 2.0
-  ~ (the "License"); you may not use this file except in compliance with
-  ~ the License.  You may obtain a copy of the License at
-  ~
-  ~    http://www.apache.org/licenses/LICENSE-2.0
-  ~
-  ~ Unless required by applicable law or agreed to in writing, software
-  ~ distributed under the License is distributed on an "AS IS" BASIS,
-  ~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-  ~ See the License for the specific language governing permissions and
-  ~ limitations under the License.
-  ~
-  -->
-
-<div fxLayout="column" class="page-container">
-    <div fxLayout="row" class="p-0 sp-bg-lightgray page-container-nav">
-        <div fxLayout="fill">
-            <div fxFlex="100" class="page-container-nav">
-                <nav mat-tab-nav-bar color="accent">
-                  <a mat-tab-link
-                     (click)="navigateTo('general')"
-                     [active]="activeLink === 'general'"> 
-                      General
-                  </a>
-                  <a mat-tab-link
-                     (click)="navigateTo('datalake')"
-                     [active]="activeLink === 'datalake'"> 
-                      DataLake
-                  </a>
-                  <a mat-tab-link
-                     (click)="navigateTo('email')"
-                     [active]="activeLink === 'email'"> 
-                      Mail
-                  </a>
-                  <a mat-tab-link
-                     (click)="navigateTo('messaging')"
-                     [active]="activeLink === 'messaging'"> 
-                      Messaging
-                  </a>
-                  <a mat-tab-link
-                     (click)="navigateTo('pipelineelement')"
-                     [active]="activeLink === 'pipelineelement'"> 
-                      Pipeline Element Configuration
-                  </a>
-                  <a mat-tab-link
-                     (click)="navigateTo('security')"
-                     [active]="activeLink === 'security'"> 
-                     Security 
-                  </a>
-                </nav>
-              </div>
-        </div>
-    </div>
-
-    <div class="fixed-height page-container-padding-inner" fxLayout="column" fxFlex="100">
-        <ng-content fxFlex="100"></ng-content>
-    </div>
-</div>
diff --git a/ui/src/app/configuration/configuration.component.spec.ts b/ui/src/app/configuration/configuration.component.spec.ts
deleted file mode 100644
index 21ca1caf7..000000000
--- a/ui/src/app/configuration/configuration.component.spec.ts
+++ /dev/null
@@ -1,57 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one or more
- * contributor license agreements.  See the NOTICE file distributed with
- * this work for additional information regarding copyright ownership.
- * The ASF licenses this file to You under the Apache License, Version 2.0
- * (the "License"); you may not use this file except in compliance with
- * the License.  You may obtain a copy of the License at
- *
- *    http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- *
- */
-
-import { ComponentFixture, TestBed, waitForAsync } from '@angular/core/testing';
-import { ConfigurationComponent } from './configuration.component';
-import { CommonModule } from '@angular/common';
-import { FlexLayoutModule } from '@angular/flex-layout';
-import { ConfigurationService } from './shared/configuration.service';
-import { ConfigurationMockService } from './shared/configuration.test.service';
-import { NO_ERRORS_SCHEMA } from '@angular/core';
-
-describe('ConfigurationComponent', () => {
-
-  let fixture: ComponentFixture<ConfigurationComponent>;
-  let configurationComponent: ConfigurationComponent;
-
-  beforeEach(waitForAsync(() => {
-    TestBed.configureTestingModule({
-      imports: [
-        CommonModule,
-        FlexLayoutModule
-      ],
-      declarations: [
-        ConfigurationComponent
-      ],
-      providers: [
-        { provide: ConfigurationService, useClass: ConfigurationMockService }
-      ],
-      schemas: [
-        NO_ERRORS_SCHEMA
-      ]
-    }).compileComponents();
-    fixture = TestBed.createComponent(ConfigurationComponent);
-    fixture.detectChanges();
-    configurationComponent = fixture.componentInstance;
-  }));
-
-  it('should create the component', waitForAsync(() => {
-    expect(configurationComponent).toBeTruthy();
-  }));
-
-});
diff --git a/ui/src/app/configuration/configuration.component.ts b/ui/src/app/configuration/configuration.component.ts
deleted file mode 100644
index 6265c82e7..000000000
--- a/ui/src/app/configuration/configuration.component.ts
+++ /dev/null
@@ -1,47 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one or more
- * contributor license agreements.  See the NOTICE file distributed with
- * this work for additional information regarding copyright ownership.
- * The ASF licenses this file to You under the Apache License, Version 2.0
- * (the "License"); you may not use this file except in compliance with
- * the License.  You may obtain a copy of the License at
- *
- *    http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- *
- */
-
-import { Component, Input } from '@angular/core';
-import { animate, state, style, transition, trigger } from '@angular/animations';
-import { Router } from '@angular/router';
-
-@Component({
-    selector: 'sp-configuration-component',
-    templateUrl: './configuration.component.html',
-    styleUrls: ['./configuration.component.css'],
-    animations: [
-        trigger('detailExpand', [
-            state('collapsed', style({height: '0px', minHeight: '0', display: 'none'})),
-            state('expanded', style({height: '*'})),
-            transition('expanded <=> collapsed', animate('225ms cubic-bezier(0.4, 0.0, 0.2, 1)')),
-        ]),
-    ]
-})
-export class ConfigurationComponent {
-
-    @Input()
-    activeLink: string;
-
-    constructor(private router: Router) {
-    }
-
-    navigateTo(routeId: string): void {
-      this.router.navigate(['configuration', routeId]);
-    }
-
-}
diff --git a/ui/src/app/configuration/configuration.module.ts b/ui/src/app/configuration/configuration.module.ts
index 4bb6be8ef..4fa292d00 100644
--- a/ui/src/app/configuration/configuration.module.ts
+++ b/ui/src/app/configuration/configuration.module.ts
@@ -16,45 +16,43 @@
  *
  */
 
-import { NgModule } from "@angular/core";
-import { MatButtonModule } from "@angular/material/button";
-import { MatCheckboxModule } from "@angular/material/checkbox";
-import { MatGridListModule } from "@angular/material/grid-list";
-import { MatIconModule } from "@angular/material/icon";
-import { MatInputModule } from "@angular/material/input";
-import { MatTooltipModule } from "@angular/material/tooltip";
-import { FlexLayoutModule } from "@angular/flex-layout";
-import { CommonModule } from "@angular/common";
-import { FormsModule, ReactiveFormsModule } from "@angular/forms";
-
-import { ConfigurationComponent } from "./configuration.component";
-import { ConfigurationService } from "./shared/configuration.service";
-import { ConsulServiceComponent } from "./consul-service/consul-service.component";
-import { ConsulConfigsComponent } from "./consul-configs/consul-configs.component";
-import { ConsulConfigsTextComponent } from "./consul-configs-text/consul-configs-text.component";
-import { ConsulConfigsPasswordComponent } from "./consul-configs-password/consul-configs-password.component";
-import { ConsulConfigsBooleanComponent } from "./consul-configs-boolean/consul-configs-boolean.component";
-import { ConsulConfigsNumberComponent } from "./consul-configs-number/consul-configs-number.component";
-import { CustomMaterialModule } from "../CustomMaterial/custom-material.module";
-import { PipelineElementConfigurationComponent } from "./pipeline-element-configuration/pipeline-element-configuration.component";
-import { MessagingConfigurationComponent } from "./messaging-configuration/messaging-configuration.component";
-import { DragDropModule } from "@angular/cdk/drag-drop";
-import { DatalakeConfigurationComponent } from "./datalake-configuration/datalake-configuration.component";
-import { DeleteDatalakeIndexComponent } from "./dialog/delete-datalake-index/delete-datalake-index-dialog.component";
-import { MatProgressSpinnerModule } from "@angular/material/progress-spinner";
-import { SecurityConfigurationComponent } from "./security-configuration/security-configuration.component";
-import { CoreUiModule } from "../core-ui/core-ui.module";
-import { MatDividerModule } from "@angular/material/divider";
-import { SecurityUserConfigComponent } from "./security-configuration/security-user-configuration/security-user-config.component";
-import { SecurityServiceConfigComponent } from "./security-configuration/security-service-configuration/security-service-config.component";
-import { EditUserDialogComponent } from "./security-configuration/edit-user-dialog/edit-user-dialog.component";
-import { PlatformServicesModule } from "@streampipes/platform-services";
-import { SecurityUserGroupConfigComponent } from "./security-configuration/user-group-configuration/user-group-configuration.component";
-import { EditGroupDialogComponent } from "./security-configuration/edit-group-dialog/edit-group-dialog.component";
-import { EmailConfigurationComponent } from "./email-configuration/email-configuration.component";
-import { GeneralConfigurationComponent } from "./general-configuration/general-configuration.component";
-import { SecurityAuthenticationConfigurationComponent } from "./security-configuration/authentication-configuration/authentication-configuration.component";
-import { RouterModule } from "@angular/router";
+import { NgModule } from '@angular/core';
+import { MatButtonModule } from '@angular/material/button';
+import { MatCheckboxModule } from '@angular/material/checkbox';
+import { MatGridListModule } from '@angular/material/grid-list';
+import { MatIconModule } from '@angular/material/icon';
+import { MatInputModule } from '@angular/material/input';
+import { MatTooltipModule } from '@angular/material/tooltip';
+import { FlexLayoutModule } from '@angular/flex-layout';
+import { CommonModule } from '@angular/common';
+import { FormsModule, ReactiveFormsModule } from '@angular/forms';
+import { ConfigurationService } from './shared/configuration.service';
+import { ConsulServiceComponent } from './consul-service/consul-service.component';
+import { ConsulConfigsComponent } from './consul-configs/consul-configs.component';
+import { ConsulConfigsTextComponent } from './consul-configs-text/consul-configs-text.component';
+import { ConsulConfigsPasswordComponent } from './consul-configs-password/consul-configs-password.component';
+import { ConsulConfigsBooleanComponent } from './consul-configs-boolean/consul-configs-boolean.component';
+import { ConsulConfigsNumberComponent } from './consul-configs-number/consul-configs-number.component';
+import { CustomMaterialModule } from '../CustomMaterial/custom-material.module';
+import { PipelineElementConfigurationComponent } from './pipeline-element-configuration/pipeline-element-configuration.component';
+import { MessagingConfigurationComponent } from './messaging-configuration/messaging-configuration.component';
+import { DragDropModule } from '@angular/cdk/drag-drop';
+import { DatalakeConfigurationComponent } from './datalake-configuration/datalake-configuration.component';
+import { DeleteDatalakeIndexComponent } from './dialog/delete-datalake-index/delete-datalake-index-dialog.component';
+import { MatProgressSpinnerModule } from '@angular/material/progress-spinner';
+import { SecurityConfigurationComponent } from './security-configuration/security-configuration.component';
+import { CoreUiModule } from '../core-ui/core-ui.module';
+import { MatDividerModule } from '@angular/material/divider';
+import { SecurityUserConfigComponent } from './security-configuration/security-user-configuration/security-user-config.component';
+import { SecurityServiceConfigComponent } from './security-configuration/security-service-configuration/security-service-config.component';
+import { EditUserDialogComponent } from './security-configuration/edit-user-dialog/edit-user-dialog.component';
+import { PlatformServicesModule } from '@streampipes/platform-services';
+import { SecurityUserGroupConfigComponent } from './security-configuration/user-group-configuration/user-group-configuration.component';
+import { EditGroupDialogComponent } from './security-configuration/edit-group-dialog/edit-group-dialog.component';
+import { EmailConfigurationComponent } from './email-configuration/email-configuration.component';
+import { GeneralConfigurationComponent } from './general-configuration/general-configuration.component';
+import { SecurityAuthenticationConfigurationComponent } from './security-configuration/authentication-configuration/authentication-configuration.component';
+import { RouterModule } from '@angular/router';
 import { SharedUiModule } from '../../../dist/streampipes/shared-ui';
 
 @NgModule({
@@ -114,7 +112,6 @@ import { SharedUiModule } from '../../../dist/streampipes/shared-ui';
     SharedUiModule,
   ],
   declarations: [
-    ConfigurationComponent,
     ConsulServiceComponent,
     ConsulConfigsComponent,
     ConsulConfigsTextComponent,