You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@aurora.apache.org by Bill Farner <wf...@apache.org> on 2013/12/18 07:06:42 UTC
Review Request 16344: Wholesale dependency updates.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16344/
-----------------------------------------------------------
Review request for Aurora, Kevin Sweeney, Suman Karumuri, Maxim Khutornenko, and Zameer Manji.
Repository: aurora
Description
-------
This is mostly to open the discussion of bumping our dependencies. This does cause a good number of conflicts most of which are trivial (read: no-op) version mismatches with twitter-common deps. The biggest real mismatch is guava (14.0.1 vs 15.0).
Diffs
-----
build.gradle 9d67d14c9afb8594888e25c8e2d17dcf8369207f
Diff: https://reviews.apache.org/r/16344/diff/
Testing
-------
./gradlew clean test
Thanks,
Bill Farner
Re: Review Request 16344: Wholesale dependency updates.
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16344/#review30616
-----------------------------------------------------------
build.gradle
<https://reviews.apache.org/r/16344/#comment58629>
This could be quite an effort, given its popularity in science:
$ ./pants goal dependees 3rdparty:guava | wc -l
1002
The release page does not suggest too many breaking changes. Though there are some (like Hasher.putString) that would need to be addressed in science. https://code.google.com/p/guava-libraries/wiki/Release15
The scariest part is a pretty significant deprecation list and possible behavior changes resulting from switching to the new functionality. Hope we have enough unit tests there to deal with it.
- Maxim Khutornenko
On Dec. 18, 2013, 6:06 a.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16344/
> -----------------------------------------------------------
>
> (Updated Dec. 18, 2013, 6:06 a.m.)
>
>
> Review request for Aurora, Kevin Sweeney, Suman Karumuri, Maxim Khutornenko, and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This is mostly to open the discussion of bumping our dependencies. This does cause a good number of conflicts most of which are trivial (read: no-op) version mismatches with twitter-common deps. The biggest real mismatch is guava (14.0.1 vs 15.0).
>
>
> Diffs
> -----
>
> build.gradle 9d67d14c9afb8594888e25c8e2d17dcf8369207f
>
> Diff: https://reviews.apache.org/r/16344/diff/
>
>
> Testing
> -------
>
> ./gradlew clean test
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 16344: Wholesale dependency updates.
Posted by Zameer Manji <zm...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16344/#review30626
-----------------------------------------------------------
I like this in principle but I'm afraid this will cause more headaches down the road.
- Zameer Manji
On Dec. 17, 2013, 10:06 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16344/
> -----------------------------------------------------------
>
> (Updated Dec. 17, 2013, 10:06 p.m.)
>
>
> Review request for Aurora, Kevin Sweeney, Suman Karumuri, Maxim Khutornenko, and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This is mostly to open the discussion of bumping our dependencies. This does cause a good number of conflicts most of which are trivial (read: no-op) version mismatches with twitter-common deps. The biggest real mismatch is guava (14.0.1 vs 15.0).
>
>
> Diffs
> -----
>
> build.gradle 9d67d14c9afb8594888e25c8e2d17dcf8369207f
>
> Diff: https://reviews.apache.org/r/16344/diff/
>
>
> Testing
> -------
>
> ./gradlew clean test
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 16344: Wholesale dependency updates.
Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16344/#review31076
-----------------------------------------------------------
I think we should first try to work with upstream to get these changes pushed up so that we can minimize overrides. Twitter commons is open-source, actively maintained, and accepts GitHub pull requests, so we should be able to get these version upgrades merged in there first. I spoke with one of the commons maintainers offline and it sounds like pull requests can be released with a relatively short (O(days)) turnaround time.
- Kevin Sweeney
On Dec. 17, 2013, 10:06 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16344/
> -----------------------------------------------------------
>
> (Updated Dec. 17, 2013, 10:06 p.m.)
>
>
> Review request for Aurora, Kevin Sweeney, Suman Karumuri, Maxim Khutornenko, and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This is mostly to open the discussion of bumping our dependencies. This does cause a good number of conflicts most of which are trivial (read: no-op) version mismatches with twitter-common deps. The biggest real mismatch is guava (14.0.1 vs 15.0).
>
>
> Diffs
> -----
>
> build.gradle 9d67d14c9afb8594888e25c8e2d17dcf8369207f
>
> Diff: https://reviews.apache.org/r/16344/diff/
>
>
> Testing
> -------
>
> ./gradlew clean test
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 16344: Wholesale dependency updates.
Posted by Suman Karumuri <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16344/#review30679
-----------------------------------------------------------
Since this a bold bet, would it be possible to test these changes along with the twitter commons parts in vagrant first?
- Suman Karumuri
On Dec. 18, 2013, 6:06 a.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16344/
> -----------------------------------------------------------
>
> (Updated Dec. 18, 2013, 6:06 a.m.)
>
>
> Review request for Aurora, Kevin Sweeney, Suman Karumuri, Maxim Khutornenko, and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This is mostly to open the discussion of bumping our dependencies. This does cause a good number of conflicts most of which are trivial (read: no-op) version mismatches with twitter-common deps. The biggest real mismatch is guava (14.0.1 vs 15.0).
>
>
> Diffs
> -----
>
> build.gradle 9d67d14c9afb8594888e25c8e2d17dcf8369207f
>
> Diff: https://reviews.apache.org/r/16344/diff/
>
>
> Testing
> -------
>
> ./gradlew clean test
>
>
> Thanks,
>
> Bill Farner
>
>