You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2016/06/23 18:45:24 UTC
[kudu-CR] lock manager: fix TSAN error in LockTable::Resize()
Todd Lipcon has uploaded a new change for review.
http://gerrit.cloudera.org:8080/3469
Change subject: lock_manager: fix TSAN error in LockTable::Resize()
......................................................................
lock_manager: fix TSAN error in LockTable::Resize()
This function was doing a non-atomic read of item_count_,
which is decremented outside the lock by Release().
I looped all_types-itest in TSAN which was previously
quite flaky and 50/50 passed:
http://dist-test.cloudera.org/job?job_id=todd.1466706366.9004
Change-Id: Id9d57c2b36bfa794cbd786641e456ad748c60941
---
M src/kudu/tablet/lock_manager.cc
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/69/3469/1
--
To view, visit http://gerrit.cloudera.org:8080/3469
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id9d57c2b36bfa794cbd786641e456ad748c60941
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
[kudu-CR] lock manager: fix TSAN error in LockTable::Resize()
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.
Change subject: lock_manager: fix TSAN error in LockTable::Resize()
......................................................................
Patch Set 1: -Verified
Build Started http://104.196.14.100/job/kudu-gerrit/1969/
--
To view, visit http://gerrit.cloudera.org:8080/3469
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id9d57c2b36bfa794cbd786641e456ad748c60941
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] lock manager: fix TSAN error in LockTable::Resize()
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: lock_manager: fix TSAN error in LockTable::Resize()
......................................................................
Patch Set 1:
We had a suppression on ScopedRowLock::Release originally (since we first introduced TSAN a couple years ago)
--
To view, visit http://gerrit.cloudera.org:8080/3469
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id9d57c2b36bfa794cbd786641e456ad748c60941
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] lock manager: fix TSAN error in LockTable::Resize()
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.
Change subject: lock_manager: fix TSAN error in LockTable::Resize()
......................................................................
Patch Set 1:
Build Started http://104.196.14.100/job/kudu-gerrit/1967/
--
To view, visit http://gerrit.cloudera.org:8080/3469
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id9d57c2b36bfa794cbd786641e456ad748c60941
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No
[kudu-CR] lock manager: fix TSAN error in LockTable::Resize()
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged.
Change subject: lock_manager: fix TSAN error in LockTable::Resize()
......................................................................
lock_manager: fix TSAN error in LockTable::Resize()
This function was doing a non-atomic read of item_count_,
which is decremented outside the lock by Release().
I looped all_types-itest in TSAN which was previously
quite flaky and 50/50 passed:
http://dist-test.cloudera.org/job?job_id=todd.1466706366.9004
Change-Id: Id9d57c2b36bfa794cbd786641e456ad748c60941
Reviewed-on: http://gerrit.cloudera.org:8080/3469
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Kudu Jenkins
---
M src/kudu/tablet/lock_manager.cc
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Adar Dembo: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/3469
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id9d57c2b36bfa794cbd786641e456ad748c60941
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] lock manager: fix TSAN error in LockTable::Resize()
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: lock_manager: fix TSAN error in LockTable::Resize()
......................................................................
Patch Set 1: Code-Review+2
Which annotation was hiding this previously?
--
To view, visit http://gerrit.cloudera.org:8080/3469
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id9d57c2b36bfa794cbd786641e456ad748c60941
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No