You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Chun-Hung Hsiao <ch...@apache.org> on 2019/03/20 21:37:59 UTC
Review Request 70258: Added a unit test for CSI `evolve` and `devolve`
helpers.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70258/
-----------------------------------------------------------
Review request for mesos, Benjamin Bannier and Jan Schlicht.
Bugs: MESOS-9625
https://issues.apache.org/jira/browse/MESOS-9625
Repository: mesos
Description
-------
Added a unit test for CSI `evolve` and `devolve` helpers.
Diffs
-----
src/Makefile.am d451d7cabe3bf5d4f5039cfac5de1b03ef891d07
src/tests/CMakeLists.txt 807ed1c7ee1c7d5582b8aa2e7d0f9e582f47fc49
src/tests/csi_utils_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/70258/diff/1/
Testing
-------
make check
Thanks,
Chun-Hung Hsiao
Re: Review Request 70258: Added a unit test for CSI `evolve` and
`devolve` helpers.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70258/#review214058
-----------------------------------------------------------
Fix it, then Ship it!
src/tests/csi_utils_tests.cpp
Lines 1 (patched)
<https://reviews.apache.org/r/70258/#comment300237>
Please consider squashing this with https://reviews.apache.org/r/70247/.
- Benjamin Bannier
On March 20, 2019, 10:37 p.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70258/
> -----------------------------------------------------------
>
> (Updated March 20, 2019, 10:37 p.m.)
>
>
> Review request for mesos, Benjamin Bannier and Jan Schlicht.
>
>
> Bugs: MESOS-9625
> https://issues.apache.org/jira/browse/MESOS-9625
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a unit test for CSI `evolve` and `devolve` helpers.
>
>
> Diffs
> -----
>
> src/Makefile.am d451d7cabe3bf5d4f5039cfac5de1b03ef891d07
> src/tests/CMakeLists.txt 807ed1c7ee1c7d5582b8aa2e7d0f9e582f47fc49
> src/tests/csi_utils_tests.cpp PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/70258/diff/2/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>